Attachment 4470 Details for Bug 4888 – Fix for IDL

[patch] Fix for IDL

0001-Fix-IDL-for-fake-string-around-OsVersion-in-GetDomai.patch (text/plain), 1.41 KB, created by Andrew Bartlett on 2009-07-24 04:09:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Bartlett

Created: 2009-07-24 04:09:42 UTC

Size: 1.41 KB

patch

obsolete

>From 004fd4a98727cb39de447bfc12092f50d3ce9191 Mon Sep 17 00:00:00 2001
>From: Andrew Bartlett <abartlet@samba.org>
>Date: Fri, 24 Jul 2009 19:05:01 +1000
>Subject: [PATCH] Fix IDL for fake string around OsVersion in GetDomainInfo
>
>I got the [value()] markers in the fake string IDL wrong here, so
>while we could parse windows requests, Windows 2008 rejected ours.
>
>Andrew Bartlett
>---
> librpc/idl/netlogon.idl |   10 ++++++----
> 1 files changed, 6 insertions(+), 4 deletions(-)
>
>diff --git a/librpc/idl/netlogon.idl b/librpc/idl/netlogon.idl
>index 9f035ac..8322566 100644
>--- a/librpc/idl/netlogon.idl
>+++ b/librpc/idl/netlogon.idl
>@@ -1277,17 +1277,19 @@ interface netlogon
> 		/* these first 3 values come from the fact windows
> 		   actually encodes this structure as a UNICODE_STRING
> 		   - see MS-NRPC section 2.2.1.3.9 */
>-		[value(284)] uint32 length;
>+
>+		/* 142 is the length of this structure in 2 byte units */
>+		[value(142)] uint32 length;
> 		[value(0)] uint32 dummy;
>-		[value(284)] uint32 size;
>+		[value(142)] uint32 size;
> 		netr_OsVersionInfoEx os;
> 	} netr_OsVersion;
> 
> 	typedef struct {
> 		/* value is 284 when info != os, otherwise 0 (for length and
> 		   size) */
>-		[value(os == NULL ? 0 : 142)] uint16 length;
>-		[value(os == NULL ? 0 : 142)] uint16 size;
>+		[value(os == NULL ? 0 : 284)] uint16 length;
>+		[value(os == NULL ? 0 : 284)] uint16 size;
> 		netr_OsVersion *os;
> 	} netr_OsVersionContainer;
> 
>-- 
>1.6.0.6
>

Actions: View

Attachments on bug 4888: 4357 | 4375 | 4376 | 4383 | 4399 | 4411 | 4452 | 4453 | 4454 | 4469 | 4470