Attachment 4295 Details for Bug 6305 – patch for master and 3.4

[patch] patch for master and 3.4

libnetapi_prompt.diff (text/plain), 1.18 KB, created by Guenther Deschner on 2009-06-16 08:10:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guenther Deschner

Created: 2009-06-16 08:10:04 UTC

Size: 1.18 KB

patch

obsolete

>From 33be1f56f778116a5657b257ffb0f1eb7196658a Mon Sep 17 00:00:00 2001
>From: =?utf-8?q?G=C3=BCnther=20Deschner?= <gd@samba.org>
>Date: Wed, 13 May 2009 23:57:26 +0200
>Subject: [PATCH] s3-netapi: Fix Bug #6305. Correctly prompt for a password when a username was given.
>
>When no callback or wrapping has managed to get a password, prompt in the
>netapi connection manager for a password.
>
>Guenther
>---
> source3/lib/netapi/cm.c |    6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
>diff --git a/source3/lib/netapi/cm.c b/source3/lib/netapi/cm.c
>index d28b2b2..55f5350 100644
>--- a/source3/lib/netapi/cm.c
>+++ b/source3/lib/netapi/cm.c
>@@ -42,8 +42,12 @@ static WERROR libnetapi_open_ipc_connection(struct libnetapi_ctx *ctx,
> 	}
> 	auth_info->signing_state = Undefined;
> 	set_cmdline_auth_info_use_kerberos(auth_info, ctx->use_kerberos);
>-	set_cmdline_auth_info_password(auth_info, ctx->password);
> 	set_cmdline_auth_info_username(auth_info, ctx->username);
>+	if (ctx->password) {
>+		set_cmdline_auth_info_password(auth_info, ctx->password);
>+	} else {
>+		set_cmdline_auth_info_getpass(auth_info);
>+	}
> 
> 	if (ctx->username && ctx->username[0] &&
> 	    ctx->password && ctx->password[0] &&
>-- 
>1.6.2.2
>

Flags:

kai: review+

Actions: View

Attachments on bug 6305: 4149 | 4269 | 4295