Attachment 4250 Details for Bug 6446 – Proposal fix

[patch] Proposal fix

0001-source4-client-client.c-fixed-two-possible-memory-le.patch (text/plain), 1.05 KB, created by Slava Semushin on 2009-06-06 11:48:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Slava Semushin

Created: 2009-06-06 11:48:31 UTC

Size: 1.05 KB

patch

obsolete

>From a79847e1852fbf980176c7e1dea0040965e6a7ab Mon Sep 17 00:00:00 2001
>From: Slava Semushin <php-coder@altlinux.ru>
>Date: Sat, 6 Jun 2009 23:43:11 +0700
>Subject: [PATCH] source4/client/client.c: fixed two possible memory leaks.
>
>Found by cppcheck:
>[./source4/client/client.c:3305]: (error) Memory leak: base_directory
>[./source4/client/client.c:3305]: (error) Memory leak: desthost
>---
> source4/client/client.c |    7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/source4/client/client.c b/source4/client/client.c
>index 018be29..82aeef3 100644
>--- a/source4/client/client.c
>+++ b/source4/client/client.c
>@@ -3290,15 +3290,18 @@ static int do_message_op(const char *netbios_name, const char *desthost,
> 			lp_gensec_settings(ctx, cmdline_lp_ctx)))
> 		return 1;
> 
>-	if (base_directory) 
>+	if (base_directory) {
> 		do_cd(ctx, base_directory);
>+		free(base_directory);
>+	}
> 	
> 	if (cmdstr) {
> 		rc = process_command_string(ctx, cmdstr);
> 	} else {
> 		rc = process_stdin(ctx);
> 	}
>-  
>+
>+	free(desthost);
> 	talloc_free(mem_ctx);
> 
> 	return rc;
>-- 
>1.6.3.1
>

Actions: View

Attachments on bug 6446: 4250