Attachment 4249 Details for Bug 6445 – Proposal fix

[patch] Proposal fix

0001-testsuite-nsswitch-get-gr-pw-ent_r.c-dump_-gr-pw-ent.patch (text/plain), 1.52 KB, created by Slava Semushin on 2009-06-06 10:03:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Slava Semushin

Created: 2009-06-06 10:03:42 UTC

Size: 1.52 KB

patch

obsolete

>From 930b463dc18220cc69556a21d576f1b4e7c338a0 Mon Sep 17 00:00:00 2001
>From: Slava Semushin <php-coder@altlinux.ru>
>Date: Sat, 6 Jun 2009 21:53:38 +0700
>Subject: [PATCH] testsuite/nsswitch/get{gr,pw}ent_r.c(dump_{gr,pw}ent): fixed wrong condition.
>
>When fopen() fails it return NULL, so condition where return value
>less than zero never evaluated to truth.
>
>Found by cppcheck.
>---
> testsuite/nsswitch/getgrent_r.c |    2 +-
> testsuite/nsswitch/getpwent_r.c |    2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/testsuite/nsswitch/getgrent_r.c b/testsuite/nsswitch/getgrent_r.c
>index 3eac8aa..4f1f0ce 100644
>--- a/testsuite/nsswitch/getgrent_r.c
>+++ b/testsuite/nsswitch/getgrent_r.c
>@@ -21,7 +21,7 @@ void dump_grent(char *id)
> 
>     sprintf(fname, "/tmp/getgrent_r-%s.out-%d", id, getpid());
> 
>-    if ((fptr = fopen(fname, "w")) < 0) {
>+    if ((fptr = fopen(fname, "w")) == NULL) {
>         fprintf(stderr, "ERROR: could not open file %s: %s\n", fname,
>                 sys_errlist[errno]);
>         return;
>diff --git a/testsuite/nsswitch/getpwent_r.c b/testsuite/nsswitch/getpwent_r.c
>index 2ba7ea9..5e77491 100644
>--- a/testsuite/nsswitch/getpwent_r.c
>+++ b/testsuite/nsswitch/getpwent_r.c
>@@ -21,7 +21,7 @@ void dump_pwent(char *id)
> 
>     sprintf(fname, "/tmp/getpwent_r-%s.out-%d", id, getpid());
> 
>-    if ((fptr = fopen(fname, "w")) < 0) {
>+    if ((fptr = fopen(fname, "w")) == 0) {
>         fprintf(stderr, "ERROR: could not open file %s: %s\n", fname,
>                 sys_errlist[errno]);
>         return;
>-- 
>1.6.3.1
>

Actions: View

Attachments on bug 6445: 4249