Attachment 4218 Details for Bug 6420 – Proposed patch

[patch] Proposed patch

0001-s3-getdcname-Fix-net-crash.patch (text/plain), 1018 bytes, created by Karolin Seeger on 2009-05-29 04:41:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Karolin Seeger

Created: 2009-05-29 04:41:38 UTC

Size: 1018 bytes

patch

obsolete

>From 1a7898e3a8f2c2e2cacd645b97da88054df931ae Mon Sep 17 00:00:00 2001
>From: Kumar Thangavelu <Kumar.Thangavelu@riverbed.com>
>Date: Fri, 29 May 2009 11:27:38 +0200
>Subject: [PATCH] s3/getdcname:  Fix 'net' crash.
>
>'net' command crashed when attempting to join a
>domain. This occurred in a very specific case where
>the DC had multiple IPs and one of the IPs was invalid.
>
>Signed-off-by: Volker Lendecke <vl@samba.org>
>---
> source3/libsmb/dsgetdcname.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/source3/libsmb/dsgetdcname.c b/source3/libsmb/dsgetdcname.c
>index 5606b8e..fb87b4d 100644
>--- a/source3/libsmb/dsgetdcname.c
>+++ b/source3/libsmb/dsgetdcname.c
>@@ -626,8 +626,8 @@ static NTSTATUS discover_dc_dns(TALLOC_CTX *mem_ctx,
> 
> 		struct ip_service_name *r = &dclist[count];
> 
>-		r->port = dcs[count].port;
>-		r->hostname = dcs[count].hostname;
>+		r->port = dcs[i].port;
>+		r->hostname = dcs[i].hostname;
> 
> 		/* If we don't have an IP list for a name, lookup it up */
> 
>-- 
>1.6.0.2
>

Flags:

gd: review+

Actions: View

Attachments on bug 6420: 4218