The Samba-Bugzilla – Attachment 4193 Details for
Bug 6398
[PATCH] Memory leaks in source4/client/smbumount.c
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Reorder checks to avoid strlen(NULL) call
0001-source4-client-smbumount.c-canonicalize-reorder-argu.patch (text/plain), 885 bytes, created by
Slava Semushin
on 2009-05-23 07:07:23 UTC
(
hide
)
Description:
Reorder checks to avoid strlen(NULL) call
Filename:
MIME Type:
Creator:
Slava Semushin
Created:
2009-05-23 07:07:23 UTC
Size:
885 bytes
patch
obsolete
>From a18e90bbd673a476dee01d428db0bb5ba06715b8 Mon Sep 17 00:00:00 2001 >From: Slava Semushin <php-coder@altlinux.ru> >Date: Sat, 23 May 2009 18:45:56 +0700 >Subject: [PATCH 1/2] source4/client/smbumount.c(canonicalize): reorder argument checks. > >Check argument for not NULL before call strlen() on it. >--- > source4/client/smbumount.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/source4/client/smbumount.c b/source4/client/smbumount.c >index 9ea3083..420b8ac 100644 >--- a/source4/client/smbumount.c >+++ b/source4/client/smbumount.c >@@ -79,14 +79,14 @@ canonicalize (char *path) > return NULL; > } > >+ if (path == NULL) >+ return NULL; >+ > if (strlen(path) > PATH_MAX) { > fprintf(stderr, "Mount point string too long\n"); > return NULL; > } > >- if (path == NULL) >- return NULL; >- > if (realpath (path, canonical)) > return canonical; > >-- >1.6.3.1 >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=4193">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Actions:
View
Attachments on
bug 6398
: 4193 |
4194