The Samba-Bugzilla – Attachment 4185 Details for
Bug 6391
[PATCH] File descriptors leak in source3/utils/log2pcaphex.c
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Fix for resource leak in source3/utils/log2pcaphex.c
0001-source3-utils-log2pcaphex.c-main-fixed-file-descript.patch (text/plain), 786 bytes, created by
Slava Semushin
on 2009-05-22 13:25:54 UTC
(
hide
)
Description:
Fix for resource leak in source3/utils/log2pcaphex.c
Filename:
MIME Type:
Creator:
Slava Semushin
Created:
2009-05-22 13:25:54 UTC
Size:
786 bytes
patch
obsolete
>From 82e1f65536a75be6141715da81a7cd1e626f18e2 Mon Sep 17 00:00:00 2001 >From: Slava Semushin <php-coder@altlinux.ru> >Date: Sat, 23 May 2009 01:10:05 +0700 >Subject: [PATCH 1/2] source3/utils/log2pcaphex.c(main): fixed file descriptors leak. > >One of leaks found by cppcheck: >[./source3/utils/log2pcaphex.c:367]: (error) Resource leak: out >--- > source3/utils/log2pcaphex.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > >diff --git a/source3/utils/log2pcaphex.c b/source3/utils/log2pcaphex.c >index 072d659..b1a8a27 100644 >--- a/source3/utils/log2pcaphex.c >+++ b/source3/utils/log2pcaphex.c >@@ -364,5 +364,13 @@ int main (int argc, char **argv) > } > } > >+ if (in != stdin) { >+ fclose(in); >+ } >+ >+ if (out != stdout) { >+ fclose(out); >+ } >+ > return 0; > } >-- >1.6.3.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 6391
: 4185