Attachment 4183 Details for Bug 6389 – Fix resource leak in lib/ldb/tools/ldbmodify.c

[patch] Fix resource leak in lib/ldb/tools/ldbmodify.c

0001-source-3-4-lib-ldb-tools-ldbmodify.c-main-fixed-reso.patch (text/plain), 1.21 KB, created by Slava Semushin on 2009-05-22 11:24:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Slava Semushin

Created: 2009-05-22 11:24:32 UTC

Size: 1.21 KB

patch

obsolete

>From c17b98ca51971dce606063f895dd38e2ffa94a90 Mon Sep 17 00:00:00 2001
>From: Slava Semushin <php-coder@altlinux.ru>
>Date: Fri, 22 May 2009 23:18:59 +0700
>Subject: [PATCH] source{3,4}/lib/ldb/tools/ldbmodify.c(main): fixed resource leak.
>
>Found by cppcheck:
>[./source3/lib/ldb/tools/ldbmodify.c:111]: (error) Resource leak: f
>[./source4/lib/ldb/tools/ldbmodify.c:108]: (error) Resource leak: f
>---
> source3/lib/ldb/tools/ldbmodify.c |    1 +
> source4/lib/ldb/tools/ldbmodify.c |    1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/source3/lib/ldb/tools/ldbmodify.c b/source3/lib/ldb/tools/ldbmodify.c
>index e3552b4..a83053d 100644
>--- a/source3/lib/ldb/tools/ldbmodify.c
>+++ b/source3/lib/ldb/tools/ldbmodify.c
>@@ -108,6 +108,7 @@ int main(int argc, const char **argv)
> 				exit(1);
> 			}
> 			ret = process_file(ldb, f, &count, &failures);
>+			fclose(f);
> 		}
> 	}
> 
>diff --git a/source4/lib/ldb/tools/ldbmodify.c b/source4/lib/ldb/tools/ldbmodify.c
>index c3f55c6..23a96a3 100644
>--- a/source4/lib/ldb/tools/ldbmodify.c
>+++ b/source4/lib/ldb/tools/ldbmodify.c
>@@ -105,6 +105,7 @@ int main(int argc, const char **argv)
> 				exit(1);
> 			}
> 			ret = process_file(ldb, f, &count);
>+			fclose(f);
> 		}
> 	}
> 
>-- 
>1.6.3.1
>

Actions: View

Attachments on bug 6389: 4183