Attachment 4159 Details for Bug 4300 – Patch to allow up to 127 byte passwords

[patch] Patch to allow up to 127 byte passwords

1.patch (text/plain), 1.24 KB, created by Steve French on 2009-05-14 15:11:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Steve French

Created: 2009-05-14 15:11:40 UTC

Size: 1.24 KB

patch

obsolete

>commit 8822c6b5b905d345dcd7122c93253e1c59d39359
>Author: Steve French <smfrench@gmail.com>
>Date:   Thu May 14 14:53:28 2009 -0500
>
>    Maximum password length check too short in mount.cifs
>    
>    Windows allows up to 127 byte passwords, and we using a 64 byte limit
>    in most places and a 16 byte limit when using the "pass=" mount option
>    
>    Acked-by: Jeff Layton <jlayton@redhat.com>
>    Signed-off-by: Steve French <sfrench@us.ibm.com>
>
>diff --git a/source/client/mount.cifs.c b/source/client/mount.cifs.c
>index 0c551cc..a5d99dc 100644
>--- a/source/client/mount.cifs.c
>+++ b/source/client/mount.cifs.c
>@@ -77,7 +77,7 @@
> #define SAFE_FREE(x) do { if ((x) != NULL) {free(x); x=NULL;} } while(0)
> #endif
> 
>-#define MOUNT_PASSWD_SIZE 64
>+#define MOUNT_PASSWD_SIZE 128
> #define DOMAIN_SIZE 64
> 
> /* currently maximum length of IPv6 address string */
>@@ -473,7 +473,7 @@ static int parse_options(char ** optionsp, int * filesys_flags)
> 					printf("\npassword specified twice, ignoring second\n");
> 				} else
> 					got_password = 1;
>-			} else if (strnlen(value, 17) < 17) {
>+			} else if (strnlen(value, MOUNT_PASSWD_SIZE) < MOUNT_PASSWD_SIZE) {
> 				if(got_password)
> 					printf("\nmount.cifs warning - password specified twice\n");
> 				got_password = 1;

Actions: View

Attachments on bug 4300: 4159