Attachment 3996 Details for Bug 6130 – patch

[patch] patch

0001-Fix-6130-Don-t-crash-in-winbindd_rpc-lookup_groupm.patch (text/plain), 1.33 KB, created by Volker Lendecke on 2009-03-16 07:21:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2009-03-16 07:21:25 UTC

Size: 1.33 KB

patch

obsolete

>From a6c122b00b88c1655b2afb6fcbbe261af1016abe Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Mon, 16 Mar 2009 13:17:04 +0100
>Subject: [PATCH] Fix #6130: Don't crash in winbindd_rpc lookup_groupmem() on unmapped members
>MIME-Version: 1.0
>Content-Type: text/plain; charset=utf-8
>Content-Transfer-Encoding: 8bit
>
>Thanks to FranÃ§ois Legal <devel@thom.fr.eu.org> for reporting this bug
>---
> source/winbindd/winbindd_rpc.c |   15 ++++++++-------
> 1 files changed, 8 insertions(+), 7 deletions(-)
>
>diff --git a/source/winbindd/winbindd_rpc.c b/source/winbindd/winbindd_rpc.c
>index b03e035..f6a9c66 100644
>--- a/source/winbindd/winbindd_rpc.c
>+++ b/source/winbindd/winbindd_rpc.c
>@@ -821,14 +821,15 @@ static NTSTATUS lookup_groupmem(struct winbindd_domain *domain,
> 		}
> 
> 		for (r=0; r<tmp_names.count; r++) {
>-			(*names)[i+r] = fill_domain_username_talloc(mem_ctx,
>-						domain->name,
>-						tmp_names.names[r].string,
>-						true);
>-			(*name_types)[i+r] = tmp_types.ids[r];
>+			if (tmp_types.ids[r] == SID_NAME_UNKNOWN) {
>+				continue;
>+			}
>+			(*names)[total_names] = fill_domain_username_talloc(
>+				mem_ctx, domain->name,
>+				tmp_names.names[r].string, true);
>+			(*name_types)[total_names] = tmp_types.ids[r];
>+			total_names += 1;
> 		}
>-
>-		total_names += tmp_names.count;
>         }
> 
>         *num_names = total_names;
>-- 
>1.6.1.3
>

Actions: View

Attachments on bug 6130: 3956 | 3994 | 3996