From 08a51e08979f91dc93d71ff8d3d2c2fdd851c75d Mon Sep 17 00:00:00 2001 From: SATOH Fumiyasu Date: Thu, 5 Feb 2009 14:19:37 +0900 Subject: [PATCH] pam_winbind: Fix password change function on Solaris Remove a redundant pam_set_item() call for a PAM item "PAM_OLDAUTHTOK" because it was already stored in _winbind_read_password() or a previous stacked PAM module. On Solaris 10, pam_set_item() call with an item value (char * for current password, i.e. PAM_OLDAUTHTOK) that is taken from pam_get_item() breaks the item content in PAM. https://bugzilla.samba.org/show_bug.cgi?id=5432 --- source/nsswitch/pam_winbind.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/source/nsswitch/pam_winbind.c b/source/nsswitch/pam_winbind.c index ad063c3..7d55c73 100644 --- a/source/nsswitch/pam_winbind.c +++ b/source/nsswitch/pam_winbind.c @@ -2538,14 +2538,6 @@ int pam_sm_chauthtok(pam_handle_t * pamh, int flags, pam_set_data(pamh, PAM_WINBIND_PWD_LAST_SET, (void *)pwdlastset_prelim, NULL); - - ret = pam_set_item(pamh, PAM_OLDAUTHTOK, - (const void *) pass_old); - pass_old = NULL; - if (ret != PAM_SUCCESS) { - _pam_log(ctx, LOG_CRIT, - "failed to set PAM_OLDAUTHTOK"); - } } else if (flags & PAM_UPDATE_AUTHTOK) { time_t pwdlastset_update = 0; -- 1.5.6.5