The Samba-Bugzilla – Attachment 3705 Details for
Bug 5860
"string overflow in safe_strcpy" if "mangled names = no"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
proposed patch
0001-Fix-bug-5860-safe_strcpy-gives-a-nasty-error-messag.patch (text/plain), 797 bytes, created by
Volker Lendecke
on 2008-11-02 03:27:35 UTC
(
hide
)
Description:
proposed patch
Filename:
MIME Type:
Creator:
Volker Lendecke
Created:
2008-11-02 03:27:35 UTC
Size:
797 bytes
patch
obsolete
>From c0ae05895453c5f0738d5af80e112c3fe1f281ac Mon Sep 17 00:00:00 2001 >From: Volker Lendecke <vl@samba.org> >Date: Sun, 2 Nov 2008 10:28:00 +0100 >Subject: [PATCH] Fix bug 5860: safe_strcpy gives a nasty error message for overlong strings > >Thanks to Robert Dahlem <Robert.Dahlem@gmx.net> for reporting this! >--- > source/smbd/mangle.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/source/smbd/mangle.c b/source/smbd/mangle.c >index 360692c..4d4d0dc 100644 >--- a/source/smbd/mangle.c >+++ b/source/smbd/mangle.c >@@ -140,7 +140,7 @@ bool name_to_8_3(const char *in, > /* name mangling can be disabled for speed, in which case > we just truncate the string */ > if (!lp_manglednames(p)) { >- safe_strcpy(out,in,12); >+ strlcpy(out, in, 13); > return True; > } > >-- >1.5.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 5860
:
3699
|
3700
| 3705