Attachment 3457 Details for Bug 4717 – An enhanced patch which corrects the "ck" command too and doesn't append every time a "(null)" when the key isn't changed.

[patch] An enhanced patch which corrects the "ck" command too and doesn't append every time a "(null)" when the key isn't changed.

regshell.patch (text/plain), 1.21 KB, created by Matthias Dieter Wallnöfer on 2008-08-07 12:22:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthias Dieter Wallnöfer

Created: 2008-08-07 12:22:10 UTC

Size: 1.21 KB

patch

obsolete

>diff --git a/source/lib/registry/tools/regshell.c b/source/lib/registry/tools/regshell.c
>index 4e859df..ee8f366 100644
>--- a/source/lib/registry/tools/regshell.c
>+++ b/source/lib/registry/tools/regshell.c
>@@ -162,9 +162,7 @@ static WERROR cmd_ck(struct regshell_context *ctx, int argc, char **argv)
> 	struct registry_key *new = NULL;
> 	WERROR error;
> 
>-	if(argc < 2) {
>-		new = ctx->current;
>-	} else {
>+	if(argc == 2) {
> 		error = reg_open_key(ctx->registry, ctx->current, argv[1],
> 				     &new);
> 		if(!W_ERROR_IS_OK(error)) {
>@@ -172,11 +170,11 @@ static WERROR cmd_ck(struct regshell_context *ctx, int argc, char **argv)
> 				win_errstr(error)));
> 			return error;
> 		}
>-	}
> 
>-	ctx->path = talloc_asprintf(ctx, "%s\\%s", ctx->path, argv[1]);
>-	printf("Current path is: %s\n", ctx->path);
>-	ctx->current = new;
>+		ctx->path = talloc_asprintf(ctx, "%s\\%s", ctx->path, argv[1]);
>+		ctx->current = new;
>+	}
>+	printf("New path is: %s\n", ctx->path);
> 
> 	return WERR_OK;
> }
>@@ -188,7 +186,7 @@ static WERROR cmd_print(struct regshell_context *ctx, int argc, char **argv)
> 	WERROR error;
> 
> 	if (argc != 2) {
>-		fprintf(stderr, "Usage: print <valuename>");
>+		fprintf(stderr, "Usage: print <valuename>\n");
> 		return WERR_INVALID_PARAM;
> 	}
>

Actions: View

Attachments on bug 4717: 2771 | 3456 | 3457