Attachment 2957 Details for Bug 4308 – Patch to 3.0.26a: Fix or improvement to the bug by adding a couple of security context switches.

[patch] Patch to 3.0.26a: Fix or improvement to the bug by adding a couple of security context switches.

bug4308.patch (text/plain), 1.03 KB, created by Michael Adam on 2007-10-30 10:52:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Adam

Created: 2007-10-30 10:52:56 UTC

Size: 1.03 KB

patch

obsolete

>diff -rNu samba-3.0.26a.orig/source/auth/auth_util.c samba-3.0.26a/source/auth/auth_util.c
>--- samba-3.0.26a.orig/source/auth/auth_util.c	2007-06-19 19:11:34.000000000 +0200
>+++ samba-3.0.26a/source/auth/auth_util.c	2007-10-30 15:10:20.000000000 +0100
>@@ -949,6 +949,8 @@
> 	
> 	if (lp_winbind_nested_groups()) {
> 
>+		become_root();
>+
> 		/* Now add the aliases. First the one from our local SAM */
> 
> 		status = add_aliases(get_global_sam_sid(), result);
>@@ -966,6 +968,8 @@
> 			TALLOC_FREE(result);
> 			return NULL;
> 		}
>+
>+		unbecome_root();
> 	} 
> 
> 
>@@ -1112,6 +1116,7 @@
> 	}
> 
> 	if (sid_check_is_in_our_domain(&user_sid)) {
>+		BOOL ret;
> 
> 		/* This is a passdb user, so ask passdb */
> 
>@@ -1122,7 +1127,11 @@
> 			goto done;
> 		}
> 
>-		if (!pdb_getsampwsid(sam_acct, &user_sid)) {
>+		become_root();
>+		ret = pdb_getsampwsid(sam_acct, &user_sid);
>+		unbecome_root();
>+
>+		if (!ret) {
> 			DEBUG(1, ("pdb_getsampwsid(%s) for user %s failed\n",
> 				  sid_string_static(&user_sid), username));
> 			DEBUGADD(1, ("Fall back to unix user %s\n", username));

Actions: View

Attachments on bug 4308: 2780 | 2814 | 2818 | 2957 | 3733 | 3750 | 3751 | 3882 | 3883 | 3884 | 3885 | 3886 | 3887