The Samba-Bugzilla – Attachment 2933 Details for
Bug 4998
[PATCH] rsync returns from fork before a valid pidfile is created
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
create the pidfile sooner
rsync-pidearly.patch (text/plain), 1.17 KB, created by
Roy Marples
on 2007-09-28 08:04:05 UTC
(
hide
)
Description:
create the pidfile sooner
Filename:
MIME Type:
Creator:
Roy Marples
Created:
2007-09-28 08:04:05 UTC
Size:
1.17 KB
patch
obsolete
>diff -ur a/clientserver.c b/clientserver.c >--- a/clientserver.c 2006-10-24 01:36:42 +0100 >+++ b/clientserver.c 2007-09-20 10:17:50 +0100 >@@ -830,21 +830,14 @@ > return start_daemon(STDIN_FILENO, STDIN_FILENO); > } > >- if (!no_detach) >- become_daemon(); >- > if (!lp_load(config_file, 1)) > exit_cleanup(RERR_SYNTAX); > >- if (rsync_port == 0 && (rsync_port = lp_rsync_port()) == 0) >- rsync_port = RSYNC_PORT; >- if (bind_address == NULL && *lp_bind_address()) >- bind_address = lp_bind_address(); >- > log_init(0); > >- rprintf(FLOG, "rsyncd version %s starting, listening on port %d\n", >- RSYNC_VERSION, rsync_port); >+ if (!no_detach) >+ become_daemon(); >+ > /* TODO: If listening on a particular address, then show that > * address too. In fact, why not just do inet_ntop on the > * local address??? */ >@@ -866,6 +859,14 @@ > close(fd); > } > >+ if (rsync_port == 0 && (rsync_port = lp_rsync_port()) == 0) >+ rsync_port = RSYNC_PORT; >+ if (bind_address == NULL && *lp_bind_address()) >+ bind_address = lp_bind_address(); >+ >+ rprintf(FLOG, "rsyncd version %s starting, listening on port %d\n", >+ RSYNC_VERSION, rsync_port); >+ > start_accept_loop(rsync_port, start_daemon); > return -1; > }
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 4998
: 2933