Attachment 2886 Details for Bug 4893 – Here a patch. The error was caused by info1 that is'nt talloced but rather static.

[patch] Here a patch. The error was caused by info1 that is'nt talloced but rather static.

cracknames.patch (text/plain), 1.45 KB, created by Matthias Dieter Wallnöfer on 2007-08-25 05:32:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matthias Dieter Wallnöfer

Created: 2007-08-25 05:32:35 UTC

Size: 1.45 KB

patch

obsolete

>Index: cracknames.c
>===================================================================
>--- cracknames.c	(revision 24655)
>+++ cracknames.c	(working copy)
>@@ -45,7 +45,7 @@
> 					struct ldb_dn *name_dn, const char *name, 
> 					struct drsuapi_DsNameInfo1 *info1);
> 
>-static WERROR dns_domain_from_principal(struct smb_krb5_context *smb_krb5_context, 
>+static WERROR dns_domain_from_principal(TALLOC_CTX *mem_ctx, struct smb_krb5_context *smb_krb5_context, 
> 					const char *name, 
> 					struct drsuapi_DsNameInfo1 *info1) 
> {
>@@ -63,7 +63,7 @@
> 	/* This isn't an allocation assignemnt, so it is free'ed with the krb5_free_principal */
> 	realm = krb5_princ_realm(smb_krb5_context->krb5_context, principal);
> 	
>-	info1->dns_domain_name	= talloc_strdup(info1, *realm);
>+	info1->dns_domain_name	= talloc_strdup(mem_ctx, *realm);
> 	krb5_free_principal(smb_krb5_context->krb5_context, principal);
> 	
> 	W_ERROR_HAVE_NO_MEMORY(info1->dns_domain_name);
>@@ -298,7 +298,7 @@
> 	case 1:
> 		break;
> 	case 0:
>-		return dns_domain_from_principal(smb_krb5_context, 
>+		return dns_domain_from_principal(mem_ctx, smb_krb5_context, 
> 						 name, info1);
> 	case -1:
> 		DEBUG(2, ("DsCrackNameUPN domain ref search failed: %s", ldb_errstring(sam_ctx)));
>@@ -560,7 +560,7 @@
> 		if (ret) {
> 			krb5_free_principal(smb_krb5_context->krb5_context, principal);
> 
>-			return dns_domain_from_principal(smb_krb5_context,
>+			return dns_domain_from_principal(mem_ctx, smb_krb5_context,
> 							 name, info1);
> 		}
>

Actions: View

Attachments on bug 4893: 2869 | 2886