The Samba-Bugzilla – Attachment 2223 Details for
Bug 4235
ntlm_auth sends BH responses without a message
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Add missing messages.
ntlm_auth.c.diff (text/plain), 7.12 KB, created by
Pawel Worach
on 2006-11-17 08:52:21 UTC
(
hide
)
Description:
Add missing messages.
Filename:
MIME Type:
Creator:
Pawel Worach
Created:
2006-11-17 08:52:21 UTC
Size:
7.12 KB
patch
obsolete
>--- source/utils/ntlm_auth.c.orig Fri Nov 17 15:33:55 2006 >+++ source/utils/ntlm_auth.c Fri Nov 17 15:45:52 2006 >@@ -542,7 +542,7 @@ > > if (strlen(buf) < 2) { > DEBUG(1, ("NTLMSSP query [%s] invalid", buf)); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH NTLMSSP query invalid\n"); > return; > } > >@@ -559,7 +559,7 @@ > > if (opt_password == NULL) { > DEBUG(1, ("Out of memory\n")); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Out of memory\n"); > data_blob_free(&request); > return; > } >@@ -576,7 +576,7 @@ > > } else { > DEBUG(1, ("NTLMSSP query [%s] invalid", buf)); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH NTLMSSP query invalid\n"); > return; > } > >@@ -624,7 +624,7 @@ > > if (strlen(buf) < 2) { > DEBUG(1, ("NTLMSSP query [%s] invalid", buf)); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH NTLMSSP query invalid\n"); > return; > } > >@@ -641,7 +641,7 @@ > > if (opt_password == NULL) { > DEBUG(1, ("Out of memory\n")); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Out of memory\n"); > data_blob_free(&request); > return; > } >@@ -668,7 +668,7 @@ > > } else { > DEBUG(1, ("NTLMSSP query [%s] invalid", buf)); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH NTLMSSP query invalid\n"); > return; > } > >@@ -777,7 +777,7 @@ > > if (len == -1) { > DEBUG(1, ("Could not write SPNEGO data blob\n")); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Could not write SPNEGO data blob\n"); > return; > } > >@@ -808,7 +808,7 @@ > > if (strlen(buf) < 2) { > DEBUG(1, ("SPENGO query [%s] invalid", buf)); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH SPENGO query invalid\n"); > return; > } > >@@ -819,7 +819,7 @@ > > } else { > DEBUG(1, ("SPENGO query [%s] invalid", buf)); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH SPENGO query invalid\n"); > return; > } > >@@ -836,7 +836,7 @@ > > if (strlen(buf) <= 3) { > DEBUG(1, ("GSS-SPNEGO query [%s] invalid\n", buf)); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH GSS-SPNEGO query invalid\n"); > return; > } > >@@ -846,7 +846,7 @@ > > if (len == -1) { > DEBUG(1, ("GSS-SPNEGO query [%s] invalid", buf)); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH GSS-SPNEGO query invalid\n"); > return; > } > >@@ -858,7 +858,7 @@ > if ( (request.negTokenInit.mechTypes == NULL) || > (request.negTokenInit.mechTypes[0] == NULL) ) { > DEBUG(1, ("Client did not offer any mechanism")); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Client did not offer any mechanism\n"); > return; > } > >@@ -866,15 +866,15 @@ > if (strcmp(request.negTokenInit.mechTypes[0], OID_NTLMSSP) == 0) { > > if ( request.negTokenInit.mechToken.data == NULL ) { >- DEBUG(1, ("Client did not provide NTLMSSP data\n")); >- x_fprintf(x_stdout, "BH\n"); >+ DEBUG(1, ("Client did not provide NTLMSSP data\n")); >+ x_fprintf(x_stdout, "BH Client did not provide NTLMSSP data\n"); > return; > } > > if ( ntlmssp_state != NULL ) { > DEBUG(1, ("Client wants a new NTLMSSP challenge, but " > "already got one\n")); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Client wants a new NTLMSSP challenge, but already got one\n"); > ntlmssp_end(&ntlmssp_state); > return; > } >@@ -907,7 +907,7 @@ > > if ( request.negTokenInit.mechToken.data == NULL ) { > DEBUG(1, ("Client did not provide Kerberos data\n")); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Client did not provide Kerberos data\n"); > return; > } > >@@ -933,7 +933,7 @@ > if (domain == NULL) { > DEBUG(1, ("Did not get a valid principal " > "from ads_verify_ticket\n")); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Did not get a valid principal from ads_verify_ticket\n"); > return; > } > >@@ -956,13 +956,13 @@ > is the only one we support that sends this stuff */ > DEBUG(1, ("Got a negTokenTarg for something non-NTLMSSP: %s\n", > request.negTokenTarg.supportedMech)); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Got a negTokenTarg for something non-NTLMSSP\n"); > return; > } > > if (request.negTokenTarg.responseToken.data == NULL) { > DEBUG(1, ("Got a negTokenTarg without a responseToken!\n")); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Got a negTokenTarg without a responseToken!\n"); > return; > } > >@@ -1006,7 +1006,7 @@ > > if (len == -1) { > DEBUG(1, ("Could not write SPNEGO data blob\n")); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Could not write SPNEGO data blob\n"); > return; > } > >@@ -1096,7 +1096,7 @@ > > if (client_ntlmssp_state == NULL) { > DEBUG(1, ("Got NTLMSSP tArg without a client state\n")); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Got NTLMSSP tArg without a client state\n"); > return; > } > >@@ -1120,7 +1120,7 @@ > DEBUG(1, ("Expected MORE_PROCESSING_REQUIRED from " > "ntlmssp_client_update, got: %s\n", > nt_errstr(status))); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Expected MORE_PROCESSING_REQUIRED from ntlmssp_client_update\n"); > data_blob_free(&request); > ntlmssp_end(&client_ntlmssp_state); > return; >@@ -1235,7 +1235,7 @@ > switch (spnego.negTokenTarg.negResult) { > case SPNEGO_ACCEPT_INCOMPLETE: > DEBUG(1, ("Got a Kerberos negTokenTarg with ACCEPT_INCOMPLETE\n")); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Got a Kerberos negTokenTarg with ACCEPT_INCOMPLETE\n"); > break; > case SPNEGO_ACCEPT_COMPLETED: > DEBUG(10, ("Accept completed\n")); >@@ -1262,7 +1262,7 @@ > > if (strlen(buf) <= 3) { > DEBUG(1, ("SPNEGO query [%s] too short\n", buf)); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH SPNEGO query too short\n"); > return; > } > >@@ -1276,7 +1276,7 @@ > > if (opt_password == NULL) { > DEBUG(1, ("Out of memory\n")); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Out of memory\n"); > data_blob_free(&request); > return; > } >@@ -1290,7 +1290,7 @@ > (strncmp(buf, "AF ", 3) != 0) && > (strncmp(buf, "NA ", 3) != 0) ) { > DEBUG(1, ("SPNEGO request [%s] invalid\n", buf)); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH SPNEGO request invalid\n"); > data_blob_free(&request); > return; > } >@@ -1303,7 +1303,7 @@ > > if (len == -1) { > DEBUG(1, ("Could not read SPNEGO data for [%s]\n", buf)); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Could not read SPNEGO data\n"); > return; > } > >@@ -1332,7 +1332,7 @@ > } > > DEBUG(1, ("Server offered no compatible mechanism\n")); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Server offered no compatible mechanism\n"); > return; > } > >@@ -1354,7 +1354,7 @@ > DEBUG(1, ("Got a negTokenTarg with no mech and an " > "unknown negResult: %d\n", > spnego.negTokenTarg.negResult)); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Got a negTokenTarg with no mech and an unknown negResult\n"); > } > > ntlmssp_end(&client_ntlmssp_state); >@@ -1378,7 +1378,7 @@ > } > > DEBUG(1, ("Got an SPNEGO token I could not handle [%s]!\n", buf)); >- x_fprintf(x_stdout, "BH\n"); >+ x_fprintf(x_stdout, "BH Got an SPNEGO token I could not handle\n"); > return; > > out:
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 4235
: 2223