The Samba-Bugzilla – Attachment 1956 Details for
Bug 3743
mount.cifs crashes when run as an ordinary user
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Replace comment for getusername with something that's correct, and removal of the offending call to free.
mount.cifs.c.patch (text/plain), 690 bytes, created by
Kjetil Jørgensen
on 2006-06-12 05:52:17 UTC
(
hide
)
Description:
Replace comment for getusername with something that's correct, and removal of the offending call to free.
Filename:
MIME Type:
Creator:
Kjetil Jørgensen
Created:
2006-06-12 05:52:17 UTC
Size:
690 bytes
patch
obsolete
>Index: mount.cifs.c >=================================================================== >--- mount.cifs.c (revision 16149) >+++ mount.cifs.c (working copy) >@@ -117,7 +117,9 @@ > exit(1); > } > >-/* caller frees username if necessary */ >+/* The username returned from getusername should not be free'd, and may be >+ * overwritten by subsequent calls to getusername or the getpw* functions >+ * from libc */ > static char * getusername(void) { > char *username = NULL; > struct passwd *password = getpwuid(getuid()); >@@ -1241,7 +1243,6 @@ > strcat(mountent.mnt_opts,",user="); > strcat(mountent.mnt_opts,mount_user); > } >- free(mount_user); > } > } > mountent.mnt_freq = 0;
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=1956">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Actions:
View
Attachments on
bug 3743
:
1891
| 1956