Attachment 18820 Details for Bug 15979 – backports for v4.22-test => v4.24-test PART 1

[patch] backports for v4.22-test => v4.24-test PART 1

bug15979-v4-22-to-v4-24#1.patch (text/plain), 1.35 KB, created by Noel Power on 2026-02-03 14:49:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Noel Power

Created: 2026-02-03 14:49:10 UTC

Size: 1.35 KB

patch

obsolete

>From fc1a34dcc5f0dd2af94354a51bccec370b761e6e Mon Sep 17 00:00:00 2001
>From: Samuel Cabrero <scabrero@samba.org>
>Date: Mon, 26 Jan 2026 13:36:02 +0100
>Subject: [PATCH 1/1] s3:rpc_client: Fix memory leak opening local named pipe
>
>If no local server name was passed to rpc_pipe_open_local_np() then
>get_myname() was called with NULL talloc context instead of the
>current stackframe.
>
>This was causing an increase of memory usage on busy servers with long-living
>rpcd_* workers.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=15979
>
>Signed-off-by: Samuel Cabrero <scabrero@samba.org>
>Reviewed-by: Noel Power <noel.power@suse.com>
>Reviewed-by: Volker Lendecke <vl@samba.org>
>
>Autobuild-User(master): Volker Lendecke <vl@samba.org>
>Autobuild-Date(master): Tue Jan 27 10:13:40 UTC 2026 on atb-devel-224
>
>(cherry picked from commit 24dc455362fb49ef81c99d95880e106a234ce29a)
>---
> source3/rpc_client/cli_pipe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source3/rpc_client/cli_pipe.c b/source3/rpc_client/cli_pipe.c
>index 660cda5ea91..002ead6d5f9 100644
>--- a/source3/rpc_client/cli_pipe.c
>+++ b/source3/rpc_client/cli_pipe.c
>@@ -3624,7 +3624,7 @@ NTSTATUS rpc_pipe_open_local_np(
> 	}
> 
> 	if (local_server_name == NULL) {
>-		local_server_name = get_myname(result);
>+		local_server_name = get_myname(frame);
> 	}
> 
> 	if (local_server_addr != NULL) {
>-- 
>2.51.0
>
>

Flags:

vl: review+

Actions: View

Attachments on bug 15979: 18807 | 18808 | 18809 | 18817 | 18820 | 18821