Attachment 18683 Details for Bug 15892 – patch

[patch] patch

bug-15892.txt (text/plain), 1.44 KB, created by Volker Lendecke on 2025-08-07 08:51:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2025-08-07 08:51:30 UTC

Size: 1.44 KB

patch

obsolete

>From b6ccb8b482d547f2218b3b43ce64888516676a93 Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Wed, 6 Aug 2025 15:28:29 +0200
>Subject: [PATCH] ctdb: Fix a stuck cluster lock holder after a delayed leader
> bcast
>
>If a delayed broadcast by a previous cluster lock holder arrives, the
>new legitimate leader will accept this without questioning in
>leader_handler(). Without this patch rec->leader will never be
>overwritten, and because rec->pnn != rec->leader we'll also never send
>out fresh leader broadcasts. And because we hold the cluster lock,
>nobody else can step up.
>
>Fix this in the next round of leader broadcast timeout.
>
>Bug: https://bugzilla.samba.org/show_bug.cgi?id=15892
>Signed-off-by: Volker Lendecke <vl@samba.org>
>Reviewed-by: Martin Schwenke <martin@meltin.net>
>
>Autobuild-User(master): Martin Schwenke <martins@samba.org>
>Autobuild-Date(master): Thu Aug  7 02:59:20 UTC 2025 on atb-devel-224
>
>(cherry picked from commit 1a7cfd93432a227a972b34e1eb844134173be7b0)
>---
> ctdb/server/ctdb_recoverd.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/ctdb/server/ctdb_recoverd.c b/ctdb/server/ctdb_recoverd.c
>index 11644868e46..edc89754c2c 100644
>--- a/ctdb/server/ctdb_recoverd.c
>+++ b/ctdb/server/ctdb_recoverd.c
>@@ -1902,6 +1902,7 @@ static void cluster_lock_election(struct ctdb_recoverd *rec)
> 	 * attempt to retake it.  This provides stability.
> 	 */
> 	if (cluster_lock_held(rec)) {
>+		rec->leader = rec->pnn;
> 		goto done;
> 	}
> 
>-- 
>2.39.5
>

Flags:

martins: review+

Actions: View

Attachments on bug 15892: 18683