Attachment 18671 Details for Bug 15877 – patch for 4.22 and 4.21

[patch] patch for 4.22 and 4.21

0001-Add-check-for-the-GPO-link-to-have-at-least-two-attr.patch (text/plain), 1.43 KB, created by Andreas Schneider on 2025-07-11 07:26:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Schneider

Created: 2025-07-11 07:26:10 UTC

Size: 1.43 KB

patch

obsolete

>From f2bb2711c78c88095eb1f9e235ba70b62ffc69c3 Mon Sep 17 00:00:00 2001
>From: Aleksandr Sharov <asharov@redhat.com>
>Date: Fri, 4 Jul 2025 15:32:28 +0200
>Subject: [PATCH] Add check for the GPO link to have at least two attributes
> separated by semicolumn. Allows to handle empty links.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=15877
>RN: Fix handling of empty GPO link
>
>Singed-off-by: Alex Sharov (kororland@gmail.com)
>Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
>Reviewed-by: Andreas Schneider <asn@samba.org>
>
>Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
>Autobuild-Date(master): Thu Jul 10 18:55:33 UTC 2025 on atb-devel-224
>
>(cherry picked from commit 44ee31c0258b0afb3d3f2ce17942cc86e308a690)
>---
> python/samba/gp/gpclass.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/python/samba/gp/gpclass.py b/python/samba/gp/gpclass.py
>index d86aacec138..07b4fb3e7bd 100644
>--- a/python/samba/gp/gpclass.py
>+++ b/python/samba/gp/gpclass.py
>@@ -673,8 +673,10 @@ class GP_LINK:
>         self.gp_opts = int(gPOptions)
> 
>     def gpo_parse_gplink(self, gPLink):
>+        # normally formed link looks like [LDAP://host/path;options]
>+        # empty link looks like [ ]
>         for p in gPLink.decode().split(']'):
>-            if not p:
>+            if not p or ';' not in p:
>                 continue
>             log.debug('gpo_parse_gplink: processing link')
>             p = p.lstrip('[')
>-- 
>2.50.0
>

Flags:

dbagnall: review+

Actions: View

Attachments on bug 15877: 18671