Attachment 18539 Details for Bug 15783 – Patches for v4-20-test

Patches for v4-20-test

bfixes-tmp420.txt (text/plain), 2.16 KB, created by Stefan Metzmacher on 2025-01-25 22:26:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Metzmacher

Created: 2025-01-25 22:26:48 UTC

Size: 2.16 KB

patch

obsolete

>From 08f24676b63364330b3d8f53f8ff9c661e5fe1b5 Mon Sep 17 00:00:00 2001
>From: Stefan Metzmacher <metze@samba.org>
>Date: Wed, 15 Jan 2025 11:57:12 +0100
>Subject: [PATCH 1/2] s4:auth/ntlm: let authsam_check_password_internals() add
> NETLOGON_NTLMV2_ENABLED
>
>Windows returns NETLOGON_NTLMV2_ENABLED in all
>netr_LogonSamLogon* response messages.
>Even if NTLMv1 was actually used and also
>for password authentication.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=15783
>
>Signed-off-by: Stefan Metzmacher <metze@samba.org>
>Reviewed-by: Andreas Schneider <asn@samba.org>
>(cherry picked from commit 1414004ee953975c50e0ee374684ff8e01246946)
>---
> source4/auth/ntlm/auth_sam.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/source4/auth/ntlm/auth_sam.c b/source4/auth/ntlm/auth_sam.c
>index d12045d8e1c1..35728244a8b1 100644
>--- a/source4/auth/ntlm/auth_sam.c
>+++ b/source4/auth/ntlm/auth_sam.c
>@@ -1090,6 +1090,7 @@ static NTSTATUS authsam_check_password_internals(struct auth_method_context *ctx
> 		talloc_free(tmp_ctx);
> 		return nt_status;
> 	}
>+	(*user_info_dc)->info->user_flags |= NETLOGON_NTLMV2_ENABLED;
> 
> 	result = dsdb_is_protected_user(ctx->auth_ctx->sam_ctx,
> 					(*user_info_dc)->sids,
>-- 
>2.34.1
>
>
>From 1531bfbb5d812217ed888490b53d689d0b60bb93 Mon Sep 17 00:00:00 2001
>From: Stefan Metzmacher <metze@samba.org>
>Date: Wed, 15 Jan 2025 12:41:21 +0100
>Subject: [PATCH 2/2] s3:auth: let check_sam_security() add
> NETLOGON_NTLMV2_ENABLED
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=15783
>
>Signed-off-by: Stefan Metzmacher <metze@samba.org>
>Reviewed-by: Andreas Schneider <asn@samba.org>
>(cherry picked from commit 10f38aff7c23dc20bc98cf0e02a430f8b0d7b1ad)
>---
> source3/auth/check_samsec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/source3/auth/check_samsec.c b/source3/auth/check_samsec.c
>index 1e55fedb6151..cfaf413eba0d 100644
>--- a/source3/auth/check_samsec.c
>+++ b/source3/auth/check_samsec.c
>@@ -575,6 +575,8 @@ NTSTATUS check_sam_security(const DATA_BLOB *challenge,
> 		goto done;
> 	}
> 
>+	(*server_info)->info3->base.user_flags |= NETLOGON_NTLMV2_ENABLED;
>+
> 	(*server_info)->session_key =
> 		data_blob_talloc(*server_info, user_sess_key.data,
> 				 user_sess_key.length);
>-- 
>2.34.1
>

Flags:

bjacke: review+

Actions: View

Attachments on bug 15783: 18534 | 18538 | 18539