Attachment 18390 Details for Bug 15690 – patch for Samba 4.21

[patch] patch for Samba 4.21

bug15690-v4-21.patch (text/plain), 1.43 KB, created by Jennifer Sutton on 2024-08-05 23:55:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jennifer Sutton

Created: 2024-08-05 23:55:59 UTC

Size: 1.43 KB

patch

obsolete

>From 58a7238e4b62c6472efefba65b2f55b7eafb94e2 Mon Sep 17 00:00:00 2001
>From: Jo Sutton <josutton@catalyst.net.nz>
>Date: Fri, 2 Aug 2024 10:14:52 +1200
>Subject: [PATCH] ldb: Fix ldb public library header files being unusable
>
>An accidental negation means that ldb_version.h is not installed when
>ldb is built as a public library.
>
>This is a regression introduced by commit
>625fb48326ec62a33ce0abdbfb0f6f3d33d7cc64.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=15690
>
>Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
>Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
>
>Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
>Autobuild-Date(master): Sun Aug  4 01:35:55 UTC 2024 on atb-devel-224
>
>(cherry picked from commit 5851ae555425ea2ba8e431162142ebae47be802e)
>---
> lib/ldb/wscript | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/ldb/wscript b/lib/ldb/wscript
>index eca66a7fe97..8ae95cbd6d6 100644
>--- a/lib/ldb/wscript
>+++ b/lib/ldb/wscript
>@@ -174,7 +174,7 @@ def build(bld):
>                             dep_vars=['LDB_VERSION'],
>                             target='include/ldb_version.h',
>                             public_headers='include/ldb_version.h',
>-                            public_headers_install=not bld.env.ldb_is_public_library)
>+                            public_headers_install=bld.env.ldb_is_public_library)
>     t.env.LDB_VERSION = LDB_VERSION
> 
>     bld.SAMBA_MODULE('ldb_asq',
>-- 
>2.39.1
>

Flags:

metze: review+

Actions: View

Attachments on bug 15690: 18390