Attachment 18339 Details for Bug 15661 – Patch to ignore sysvol backup when smb is not running

[patch] Patch to ignore sysvol backup when smb is not running

handle_no_smb_service.patch (text/plain), 991 bytes, created by Thomas Karlsson on 2024-06-13 17:48:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Thomas Karlsson

Created: 2024-06-13 17:48:28 UTC

Size: 991 bytes

patch

obsolete

>--- a/python/samba/netcmd/domain/backup.py
>+++ b/python/samba/netcmd/domain/backup.py
>@@ -284,9 +284,12 @@ class cmd_domain_backup_online(samba.netcmd.Command):
> 
>             # Grab the remote DC's sysvol files and bundle them into a tar file
>             logger.info("Backing up sysvol files (via SMB)...")
>-            sysvol_tar = os.path.join(tmpdir, 'sysvol.tar.gz')
>-            smb_conn = smb_sysvol_conn(server, lp, creds)
>-            backup_online(smb_conn, sysvol_tar, remote_sam.get_domain_sid())
>+            try:
>+                sysvol_tar = os.path.join(tmpdir, 'sysvol.tar.gz')
>+                smb_conn = smb_sysvol_conn(server, lp, creds)
>+                backup_online(smb_conn, sysvol_tar, remote_sam.get_domain_sid())
>+            except:
>+                logger.warning('Failed to backup sysvol files (via SMB)...')
> 
>             # remove the default sysvol files created by the clone (we want to
>             # make sure we restore the sysvol.tar.gz files instead)

Actions: View

Attachments on bug 15661: 18339 | 18364 | 18592 | 18614