Attachment 18291 Details for Bug 15633 – patch for 4.20

[patch] patch for 4.20

0001-python-Fix-NtVer-check-for-site_dn_for_machine.patch (text/plain), 1.32 KB, created by Andreas Schneider on 2024-04-22 08:44:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Schneider

Created: 2024-04-22 08:44:46 UTC

Size: 1.32 KB

patch

obsolete

>From 92dc441ffe7de554502a02725cf1831f5fb839ab Mon Sep 17 00:00:00 2001
>From: Andreas Schneider <asn@samba.org>
>Date: Mon, 15 Apr 2024 07:32:02 +0200
>Subject: [PATCH] python: Fix NtVer check for site_dn_for_machine()
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=15633
>
>Signed-off-by: Andreas Schneider <asn@samba.org>
>Reviewed-by: David Mulder <dmulder@samba.org>
>(cherry picked from commit 7a5e7b821259890dd2978e6f113f4a3dad110ea4)
>---
> python/samba/gp/gpclass.py | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/python/samba/gp/gpclass.py b/python/samba/gp/gpclass.py
>index 08be472e707..d86aacec138 100644
>--- a/python/samba/gp/gpclass.py
>+++ b/python/samba/gp/gpclass.py
>@@ -805,9 +805,7 @@ def site_dn_for_machine(samdb, dc_hostname, lp, creds, hostname):
> 
>     samlogon_response = ndr_unpack(nbt.netlogon_samlogon_response,
>                                    bytes(res.msgs[0]['Netlogon'][0]))
>-    if samlogon_response.ntver not in [nbt.NETLOGON_NT_VERSION_5EX,
>-                                       (nbt.NETLOGON_NT_VERSION_1
>-                                        | nbt.NETLOGON_NT_VERSION_5EX)]:
>+    if not (samlogon_response.ntver & nbt.NETLOGON_NT_VERSION_5EX):
>         raise RuntimeError('site_dn_for_machine: Invalid NtVer in '
>                            + 'netlogon_samlogon_response')
> 
>-- 
>2.44.0
>

Flags:

asn: review? (dmulder)
asn: review? (ab)
pfilipensky: review+

Actions: View

Attachments on bug 15633: 18291