Attachment 18115 Details for Bug 15479 – Patch for v4-19-test and v4-18-test

[patch] Patch for v4-19-test and v4-18-test

BZ15479.patch (text/plain), 1.50 KB, created by Martin Schwenke on 2023-09-21 01:09:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Schwenke

Created: 2023-09-21 01:09:51 UTC

Size: 1.50 KB

patch

obsolete

>From 87238392a7867447718b75e7434cd89a0fe776c6 Mon Sep 17 00:00:00 2001
>From: Martin Schwenke <mschwenke@ddn.com>
>Date: Tue, 19 Sep 2023 17:47:36 +1000
>Subject: [PATCH] ctdb-daemon: Call setproctitle_init()
>
>Commit 19c82c19c009eefe975ae95c8b709fc93f5f4c39 changed the behaviour
>of prctl_set_comment() so it now calls setproctitle(3bsd) by default.
>
>In some Linux distributions (e.g. Rocky Linux 8.8), this results in
>messages like this spamming the logs:
>
>  ctdbd: setproctitle not initialized, please either call setproctitle_init() or link against libbsd-ctor.
>
>Most Samba daemons seem to call setproctitle_init(), so do it here.
>
>In the longer term CTDB should also switch to using lib/util's
>process_set_title(), like the rest of Samba, for more flexible process
>names.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=15479
>
>Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
>Reviewed-by: Ralph Boehme <slow@samba.org>
>
>Autobuild-User(master): Martin Schwenke <martins@samba.org>
>Autobuild-Date(master): Thu Sep 21 00:46:50 UTC 2023 on atb-devel-224
>
>(cherry picked from commit 8b9f464420b66cebaf00654cf8b19165b301b8b6)
>---
> ctdb/server/ctdbd.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/ctdb/server/ctdbd.c b/ctdb/server/ctdbd.c
>index 10541cb21f1..a388bff1598 100644
>--- a/ctdb/server/ctdbd.c
>+++ b/ctdb/server/ctdbd.c
>@@ -170,6 +170,8 @@ int main(int argc, const char *argv[])
> 	const char *test_mode;
> 	bool ok;
> 
>+	setproctitle_init(argc, discard_const(argv), environ);
>+
> 	/*
> 	 * Basic setup
> 	 */
>-- 
>2.39.2
>

Flags:

slow: review+

Actions: View

Attachments on bug 15479: 18115