The Samba-Bugzilla – Attachment 17971 Details for
Bug 15416
cldap_ping_list doesn't reset num_requests to 0 on retry
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Patch for v4-18-test
bfixes-tmp418.txt (text/plain), 1.14 KB, created by
Stefan Metzmacher
on 2023-07-05 11:21:53 UTC
(
hide
)
Description:
Patch for v4-18-test
Filename:
MIME Type:
Creator:
Stefan Metzmacher
Created:
2023-07-05 11:21:53 UTC
Size:
1.14 KB
patch
obsolete
>From c6ac5860eca4ce6e6a59c70b04085d769cd072e7 Mon Sep 17 00:00:00 2001 >From: Stefan Metzmacher <metze@samba.org> >Date: Tue, 4 Jul 2023 18:07:12 +0200 >Subject: [PATCH] s3:libads: re-initialize num_requests to 0 for > cldap_ping_list retries > >Commit 8132edf119757ee91070facffef016c93de9c2a6 introduced a retry loop >arround cldap_multi_netlogon(), but it forgot to reset num_requests to 0 >for the retries. > >BUG: https://bugzilla.samba.org/show_bug.cgi?id=15416 > >Signed-off-by: Stefan Metzmacher <metze@samba.org> >Reviewed-by: Volker Lendecke <vl@samba.org> > >Autobuild-User(master): Volker Lendecke <vl@samba.org> >Autobuild-Date(master): Wed Jul 5 11:17:43 UTC 2023 on atb-devel-224 > >(cherry picked from commit 6965e77268e1abfc21f1793c7cd006444938ac03) >--- > source3/libads/ldap.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c >index a01b11930138..3ba32d0cf448 100755 >--- a/source3/libads/ldap.c >+++ b/source3/libads/ldap.c >@@ -446,6 +446,7 @@ again: > * The retry loop is bound by the timeout > */ > retry = false; >+ num_requests = 0; > > for (i = 0; i < count; i++) { > char server[INET6_ADDRSTRLEN]; >-- >2.34.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Flags:
vl
:
review+
metze
:
review?
(
slow
)
Actions:
View
Attachments on
bug 15416
: 17971