Attachment 17962 Details for Bug 15355 – Patch for v4-18-test

Patch for v4-18-test

bfixes-tmp418.txt (text/plain), 2.29 KB, created by Stefan Metzmacher on 2023-06-28 11:00:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Metzmacher

Created: 2023-06-28 11:00:47 UTC

Size: 2.29 KB

patch

obsolete

>From 4d622f2880fa510e981e31795215e83f122af0eb Mon Sep 17 00:00:00 2001
>From: Stefan Metzmacher <metze@samba.org>
>Date: Wed, 12 Apr 2023 17:22:02 +0200
>Subject: [PATCH] selftest:Samba3: use the correct NSS_WRAPPER_HOSTNAME
>
>The value of NSS_WRAPPER_HOSTNAME needs to match value
>we put into the NSS_WRAPPER_HOSTS file.
>
>We had a mismatch of
>idmapridmember.samba.example.com
>vs.
>idmapridmember.addom.samba.example.com
>
>This causes getaddrinfo() in nss_wrapper to fallback to
>the libc version, which talks to a dns server.
>It's not clear if recent glibc code will reach resolve/socket wrapper.
>So it's not unlikely that idmapridmember.samba.example.com will
>be passed via the internet, which causes delays up to 20 seconds.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=15355
>
>Signed-off-by: Stefan Metzmacher <metze@samba.org>
>Reviewed-by: Ralph Boehme <slow@samba.org>
>
>Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
>Autobuild-Date(master): Wed Apr 12 20:29:05 UTC 2023 on atb-devel-224
>
>(cherry picked from commit 53f0a292f8057a63ddee951058e380b43b9d2916)
>---
> selftest/target/Samba3.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
>index 0556efd47411..ba3268f147c8 100755
>--- a/selftest/target/Samba3.pm
>+++ b/selftest/target/Samba3.pm
>@@ -3678,7 +3678,7 @@ jacknomappergroup:x:$gid_jacknomapper:jacknomapper
> 	$createuser_env{NSS_WRAPPER_PASSWD} = $nss_wrapper_passwd;
> 	$createuser_env{NSS_WRAPPER_GROUP} = $nss_wrapper_group;
> 	$createuser_env{NSS_WRAPPER_HOSTS} = $nss_wrapper_hosts;
>-	$createuser_env{NSS_WRAPPER_HOSTNAME} = "${hostname}.samba.example.com";
>+	$createuser_env{NSS_WRAPPER_HOSTNAME} = "${hostname}.${dns_domain}";
> 	if ($ENV{SAMBA_DNS_FAKING}) {
> 		$createuser_env{RESOLV_WRAPPER_HOSTS} = $dns_host_file;
> 	} else {
>@@ -3732,7 +3732,7 @@ jacknomappergroup:x:$gid_jacknomapper:jacknomapper
> 	$ret{NSS_WRAPPER_PASSWD} = $nss_wrapper_passwd;
> 	$ret{NSS_WRAPPER_GROUP} = $nss_wrapper_group;
> 	$ret{NSS_WRAPPER_HOSTS} = $nss_wrapper_hosts;
>-	$ret{NSS_WRAPPER_HOSTNAME} = "${hostname}.samba.example.com";
>+	$ret{NSS_WRAPPER_HOSTNAME} = "${hostname}.${dns_domain}";
> 	$ret{NSS_WRAPPER_MODULE_SO_PATH} = Samba::nss_wrapper_winbind_so_path($self);
> 	$ret{NSS_WRAPPER_MODULE_FN_PREFIX} = "winbind";
> 	if ($ENV{SAMBA_DNS_FAKING}) {
>-- 
>2.34.1
>

Flags:

slow: review+

Actions: View

Attachments on bug 15355: 17962