Attachment 17888 Details for Bug 15374 – Patch for v4-18-test

[patch] Patch for v4-18-test

bfixes-tmp418.txt (text/plain), 1.22 KB, created by Stefan Metzmacher on 2023-05-17 07:49:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Metzmacher

Created: 2023-05-17 07:49:22 UTC

Size: 1.22 KB

patch

obsolete

>From 44220bdb60406e3e41198145ceb81754fc86cbb7 Mon Sep 17 00:00:00 2001
>From: Stefan Metzmacher <metze@samba.org>
>Date: Tue, 16 May 2023 13:09:23 +0200
>Subject: [PATCH] librpc/rpc: allow smb3_sid_parse() to accept modern
> encryption algorithms
>
>We should not limit the possible encryption algorithms to the currently
>known ones.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=15374
>
>Signed-off-by: Stefan Metzmacher <metze@samba.org>
>Reviewed-by: Volker Lendecke <vl@samba.org>
>
>Autobuild-User(master): Volker Lendecke <vl@samba.org>
>Autobuild-Date(master): Wed May 17 07:34:28 UTC 2023 on atb-devel-224
>
>(cherry picked from commit e03e738dfc96b3c8ce54e2d280143965713f4778)
>---
> librpc/rpc/dcerpc_helper.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/librpc/rpc/dcerpc_helper.c b/librpc/rpc/dcerpc_helper.c
>index cf0deeb20794..48a9a0e46d68 100644
>--- a/librpc/rpc/dcerpc_helper.c
>+++ b/librpc/rpc/dcerpc_helper.c
>@@ -48,7 +48,12 @@ static bool smb3_sid_parse(const struct dom_sid *sid,
> 	}
> 
> 	cipher = sid->sub_auths[3];
>-	if (cipher > SMB2_ENCRYPTION_AES128_GCM) {
>+	if (cipher > 256) {
>+		/*
>+		 * It is unlikely that we
>+		 * ever have more then 256
>+		 * encryption algorithms
>+		 */
> 		return false;
> 	}
> 
>-- 
>2.34.1
>

Flags:

vl: review+

Actions: View

Attachments on bug 15374: 17888 | 17889