Attachment 17866 Details for Bug 15357 – Patch for 4.18

[patch] Patch for 4.18

bug-15357-4.18.txt (text/plain), 1.28 KB, created by Volker Lendecke on 2023-04-18 07:33:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2023-04-18 07:33:07 UTC

Size: 1.28 KB

patch

obsolete

>From 4338c49c12f536b2695e68b9eea114e0cb7287f4 Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Fri, 14 Apr 2023 16:32:42 +0200
>Subject: [PATCH] streams_depot: Create files when requested
>
>If you set "create mask = 0600" no streams will be created....
>
>Tested manually. Not creating an automated test for this, there are so
>many places where this can go wrong that testing this individual
>glitch does not gain us much confidence.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=15357
>
>Signed-off-by: Volker Lendecke <vl@samba.org>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>(cherry picked from commit 081e808ab4ac6e187b9791da322eb7173e1e133c)
>---
> source3/modules/vfs_streams_depot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source3/modules/vfs_streams_depot.c b/source3/modules/vfs_streams_depot.c
>index f92e9c8c5fa..83019fa07da 100644
>--- a/source3/modules/vfs_streams_depot.c
>+++ b/source3/modules/vfs_streams_depot.c
>@@ -690,7 +690,7 @@ static int streams_depot_openat(struct vfs_handle_struct *handle,
> 	SMB_ASSERT(dirfsp == NULL);
> 	SMB_ASSERT(VALID_STAT(fsp->base_fsp->fsp_name->st));
> 
>-	create_it = (how->mode & O_CREAT);
>+	create_it = (how->flags & O_CREAT);
> 
> 	/* Determine the stream name, and then open it. */
> 	status = stream_smb_fname(
>-- 
>2.30.2
>

Flags:

slow: review+

Actions: View

Attachments on bug 15357: 17866 | 17867