From 9b4d89ce12dcba4b2473eb7510a8a171d5d088f0 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Thu, 16 Feb 2023 16:31:34 +0100 Subject: [PATCH] winbindd: don't call set_domain_online_request() in the idmap child Most idmap backends don't need access to the domain controllers. And the related code is not needed for the backends. Commit 17c86a2c5a5a5e2b194362e5f36f0f99910222c5 changed the logic of set_domain_online_request() completely! Instead of triggering a dc probe in the background, it is now doing a blocking connection. And doing this in the idmap child is completely useless. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15317 Signed-off-by: Stefan Metzmacher Reviewed-by: Jeremy Allison (cherry picked from commit ad242a20643c930eb00a8b700f7bd9638f8821a8) --- source3/winbindd/winbindd_dual.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/source3/winbindd/winbindd_dual.c b/source3/winbindd/winbindd_dual.c index 8cb59b2f752..d053977033f 100644 --- a/source3/winbindd/winbindd_dual.c +++ b/source3/winbindd/winbindd_dual.c @@ -1811,13 +1811,6 @@ static bool fork_domain_child(struct winbindd_child *child) } } - /* - * We are in idmap child, bring primary domain online. - */ - if (is_idmap_child(child)) { - set_domain_online_request(primary_domain); - } - /* We might be in the idmap child...*/ if (child->domain && !(child->domain->internal) && lp_winbind_offline_logon()) { -- 2.34.1