Attachment 17640 Details for Bug 15230 – Patch for v4-17-test

[patch] Patch for v4-17-test

bfixes-tmp417.txt (text/plain), 1014 bytes, created by Stefan Metzmacher on 2022-11-09 11:56:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Metzmacher

Created: 2022-11-09 11:56:45 UTC

Size: 1014 bytes

patch

obsolete

>From 88190083e257363993bf3a8a03c4b6f95c7faf9d Mon Sep 17 00:00:00 2001
>From: Stefan Metzmacher <metze@samba.org>
>Date: Mon, 31 Oct 2022 13:16:25 +0100
>Subject: [PATCH] lib/replace: fix memory leak in snprintf replacements
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=15230
>
>Signed-off-by: Stefan Metzmacher <metze@samba.org>
>Reviewed-by: Volker Lendecke <vl@samba.org>
>
>Autobuild-User(master): Volker Lendecke <vl@samba.org>
>Autobuild-Date(master): Wed Nov  9 11:18:02 UTC 2022 on sn-devel-184
>
>(cherry picked from commit 76adda9d2fea9f93f4cf97536db5c0be6deeb98c)
>---
> lib/replace/snprintf.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/lib/replace/snprintf.c b/lib/replace/snprintf.c
>index 6e4424b0b318..de814af41641 100644
>--- a/lib/replace/snprintf.c
>+++ b/lib/replace/snprintf.c
>@@ -751,6 +751,8 @@ done:
> 
> 	while (chunks) {
> 		cnk = chunks->next;
>+		if (chunks->min_star) free(chunks->min_star);
>+		if (chunks->max_star) free(chunks->max_star);
> 		free(chunks);
> 		chunks = cnk;
> 	}
>-- 
>2.34.1
>

Flags:

vl: review+

Actions: View

Attachments on bug 15230: 17640 | 17641