The Samba-Bugzilla – Attachment 17638 Details for
Bug 15226
samba-tool gpo listall fails IPv6 only - finddcs() fails to find DC when there is only an AAAA record for the DC in DNS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Jeremy's tested by Matthew Grant proposed fix
samba-finddcs-only-aaaa-in-dns-fix2.patch (text/plain), 678 bytes, created by
Matthew Grant
on 2022-11-08 21:05:45 UTC
(
hide
)
Description:
Jeremy's tested by Matthew Grant proposed fix
Filename:
MIME Type:
Creator:
Matthew Grant
Created:
2022-11-08 21:05:45 UTC
Size:
678 bytes
patch
obsolete
>diff --git a/source4/libcli/resolve/dns_ex.c b/source4/libcli/resolve/dns_ex.c >index 0bb3ba02287..2607c1558cb 100644 >--- a/source4/libcli/resolve/dns_ex.c >+++ b/source4/libcli/resolve/dns_ex.c >@@ -245,13 +245,11 @@ static struct dns_records_container get_a_aaaa_records(TALLOC_CTX *mem_ctx, > * Most of the server do it, let's ask for A specificaly. > */ > err = dns_lookup(tmp_ctx, name, QTYPE_A, &reply); >- if (!ERR_DNS_IS_OK(err)) { >- goto done; >+ if (ERR_DNS_IS_OK(err)) { >+ total = reply_to_addrs(tmp_ctx, &a_num, &addrs, >+ total, reply, port); > } > >- total = reply_to_addrs(tmp_ctx, &a_num, &addrs, total, >- reply, port); >- > } > > if (total) {
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=17638">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Actions:
View
Attachments on
bug 15226
:
17630
|
17637
|
17638
|
17642