The Samba-Bugzilla – Attachment 17426 Details for
Bug 15124
rpcclient can crash using setuserinfo(2)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
"raw" untested patch.
look (text/plain), 1.40 KB, created by
Jeremy Allison
on 2022-07-18 18:19:27 UTC
(
hide
)
Description:
"raw" untested patch.
Filename:
MIME Type:
Creator:
Jeremy Allison
Created:
2022-07-18 18:19:27 UTC
Size:
1.40 KB
patch
obsolete
>diff --git a/source3/rpcclient/cmd_samr.c b/source3/rpcclient/cmd_samr.c >index eb7f7fc8424..762b808c2da 100644 >--- a/source3/rpcclient/cmd_samr.c >+++ b/source3/rpcclient/cmd_samr.c >@@ -3356,16 +3356,19 @@ static NTSTATUS cmd_samr_setuserinfo_int(struct rpc_pipe_client *cli, > &types, > &result); > if (!NT_STATUS_IS_OK(status)) { >- return status; >+ goto done; > } > if (!NT_STATUS_IS_OK(result)) { >- return result; >+ status = result; >+ goto done; > } > if (rids.count != 1) { >- return NT_STATUS_INVALID_NETWORK_RESPONSE; >+ status = NT_STATUS_INVALID_NETWORK_RESPONSE; >+ goto done; > } > if (types.count != 1) { >- return NT_STATUS_INVALID_NETWORK_RESPONSE; >+ status = NT_STATUS_INVALID_NETWORK_RESPONSE; >+ goto done; > } > > status = dcerpc_samr_OpenUser(b, frame, >@@ -3375,10 +3378,11 @@ static NTSTATUS cmd_samr_setuserinfo_int(struct rpc_pipe_client *cli, > &user_pol, > &result); > if (!NT_STATUS_IS_OK(status)) { >- return status; >+ goto done; > } > if (!NT_STATUS_IS_OK(result)) { >- return result; >+ status = result; >+ goto done; > } > } > >@@ -3398,7 +3402,8 @@ static NTSTATUS cmd_samr_setuserinfo_int(struct rpc_pipe_client *cli, > &result); > break; > default: >- return NT_STATUS_INVALID_PARAMETER; >+ status = NT_STATUS_INVALID_PARAMETER; >+ goto done; > } > if (!NT_STATUS_IS_OK(status)) { > DEBUG(0,("status: %s\n", nt_errstr(status)));
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 15124
: 17426 |
17428