Attachment 17330 Details for Bug 15091 – Patch for v4-15-test

[patch] Patch for v4-15-test

bfixes-tmp415.txt (text/plain), 1.55 KB, created by Stefan Metzmacher on 2022-06-09 04:52:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Metzmacher

Created: 2022-06-09 04:52:31 UTC

Size: 1.55 KB

patch

obsolete

>From 6cdf5ec943843173b408ac71bfc12a0251fdd362 Mon Sep 17 00:00:00 2001
>From: Andreas Schneider <asn@samba.org>
>Date: Fri, 1 Oct 2021 10:46:09 +0200
>Subject: [PATCH] s3:utils: Fix format error
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>regedit_hexedit.c:166:39: error: format â%Xâ expects argument of type âunsigned
>intâ, but argument 3 has type âsize_tâ {aka âlong unsigned intâ}
>  166 |                 wprintw(buf->win, "%08X  ", off);
>      |                                    ~~~^     ~~~
>      |                                       |     |
>      |                                       |     size_t {aka long unsigned int}
>      |                                       unsigned int
>      |                                    %08lX
>
>Signed-off-by: Andreas Schneider <asn@samba.org>
>Reviewed-by: Uri Simchoni <uri@samba.org>
>
>(cherry picked from commit cc3081cebfb65181cd291702cb6a2e727dc999b2)
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=15091
>Reviewed-by: Stefan Metzmacher <metze@samba.org>
>---
> source3/utils/regedit_hexedit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source3/utils/regedit_hexedit.c b/source3/utils/regedit_hexedit.c
>index 383736ae2bcd..413e563f653f 100644
>--- a/source3/utils/regedit_hexedit.c
>+++ b/source3/utils/regedit_hexedit.c
>@@ -163,7 +163,7 @@ void hexedit_refresh(struct hexedit *buf)
> 		size_t i, endline;
> 
> 		wmove(buf->win, lineno, 0);
>-		wprintw(buf->win, "%08X  ", off);
>+		wprintw(buf->win, "%08zX  ", off);
> 
> 		endline = BYTES_PER_LINE;
> 
>-- 
>2.34.1
>

Flags:

asn: review+

Actions: View

Attachments on bug 15091: 17330