Attachment 17279 Details for Bug 15055 – Patch for 4.15

[patch] Patch for 4.15

patch-for-4.15 (text/plain), 1.49 KB, created by Christof Schmitt on 2022-04-28 15:59:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christof Schmitt

Created: 2022-04-28 15:59:41 UTC

Size: 1.49 KB

patch

obsolete

>From ce0dc67a39ecbae2445c97b99af514a1c956410a Mon Sep 17 00:00:00 2001
>From: Christof Schmitt <cs@samba.org>
>Date: Wed, 27 Apr 2022 15:37:18 -0700
>Subject: [PATCH] vfs_gpfs: Ignore pathref fds for gpfs:recalls check
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Setting gpfs:recalls=no should prevent data access to offline files.
>Since Samba 4.14, the VFS openat function is also called with O_PATH to
>get a reference to the path. These accesses should not be blocked,
>otherwise this would prevent offline files from being included in
>directory listings.
>
>Fix this by skipping the check for pathref fds.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=15055
>
>Signed-off-by: Christof Schmitt <cs@samba.org>
>Reviewed-by: Ralph Boehme <slow@samba.org>
>
>Autobuild-User(master): Ralph BÃ¶hme <slow@samba.org>
>Autobuild-Date(master): Thu Apr 28 07:59:47 UTC 2022 on sn-devel-184
>
>(cherry picked from commit 03d0dd2651c9e6552d6c3d9513810e581339ac08)
>---
> source3/modules/vfs_gpfs.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/source3/modules/vfs_gpfs.c b/source3/modules/vfs_gpfs.c
>index 70b8c7b903e..eb7a1d3e39a 100644
>--- a/source3/modules/vfs_gpfs.c
>+++ b/source3/modules/vfs_gpfs.c
>@@ -2374,6 +2374,7 @@ static int vfs_gpfs_openat(struct vfs_handle_struct *handle,
> 				return -1);
> 
> 	if (config->hsm && !config->recalls &&
>+	    !fsp->fsp_flags.is_pathref &&
> 	    vfs_gpfs_fsp_is_offline(handle, fsp))
> 	{
> 		DBG_DEBUG("Refusing access to offline file %s\n",
>-- 
>2.27.0
>

Flags:

slow: review+

Actions: View

Attachments on bug 15055: 17278 | 17279