Attachment 17244 Details for Bug 15034 – Patch for v4-14-test

[patch] Patch for v4-14-test

bfixes-tmp414.txt (text/plain), 1.45 KB, created by Stefan Metzmacher on 2022-03-25 10:41:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Stefan Metzmacher

Created: 2022-03-25 10:41:46 UTC

Size: 1.45 KB

patch

obsolete

>From 42fa60bc2a16ec1e0d95850d1bf39058d781721c Mon Sep 17 00:00:00 2001
>From: Andreas Schneider <asn@samba.org>
>Date: Mon, 14 Feb 2022 07:59:52 +0100
>Subject: [PATCH] builtools: Make abi_gen.sh less prone to errors
>
>The mold linker has more hidden symbols and we would need to filter them out
>with nm, where objdump tells us which symbols are actually hidden. So we just
>need to filter out whatever is hidden.
>
>The use of awk makes it also easier to get what we want.
>
>Signed-off-by: Andreas Schneider <asn@samba.org>
>Reviewed-by: Alexander Bokovoy <ab@samba.org>
>(cherry picked from commit 2b9917d7a3cb88cf48517e4a93a94fa3ca6ff3d9)
>---
> buildtools/scripts/abi_gen.sh | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/buildtools/scripts/abi_gen.sh b/buildtools/scripts/abi_gen.sh
>index 6dd6d321f775..ddb0a7cc36fd 100755
>--- a/buildtools/scripts/abi_gen.sh
>+++ b/buildtools/scripts/abi_gen.sh
>@@ -10,9 +10,14 @@ cat <<EOF
> set height 0
> set width 0
> EOF
>-nm "$SHAREDLIB" | cut -d' ' -f2- | egrep '^[BDGTRVWS]' | grep -v @ | egrep -v ' (__bss_start|_edata|_init|_fini|_end)' | cut -c3- | sort | while read s; do
>+
>+# On older linker versions _init|_fini symbols are not hidden.
>+objdump --dynamic-syms "${SHAREDLIB}" | \
>+    awk '$0 !~ /.hidden/ {if ($2 == "g" && $3 ~ /D(F|O)/ && $4 ~ /(.bss|.rodata|.text)/) print $NF}' | \
>+    sort | \
>+    while read -r s; do
>     echo "echo $s: "
>-    echo p $s
>+    echo p "${s}"
> done
> ) > $GDBSCRIPT
> 
>-- 
>2.25.1
>

Flags:

asn: review+

Actions: View

Attachments on bug 15034: 17242 | 17243 | 17244