Attachment 17238 Details for Bug 15006 – a patch for samba-tool gpo create

[patch] a patch for samba-tool gpo create

0001-samba-tool-gpo-clean-up-tmpdir-after-create.patch (text/plain), 1.01 KB, created by Douglas Bagnall on 2022-03-24 05:48:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Douglas Bagnall

Created: 2022-03-24 05:48:34 UTC

Size: 1.01 KB

patch

obsolete

>From 45778d755e37574678d2d4c1e3b853c36b81ecf9 Mon Sep 17 00:00:00 2001
>From: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
>Date: Thu, 24 Mar 2022 18:39:55 +1300
>Subject: [PATCH] samba-tool gpo: clean up tmpdir after create
>
>'fetch' and 'backup' might also leave files in /tmp, but in those cases
>we want the files.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=15006
>
>Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
>---
> python/samba/netcmd/gpo.py | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/python/samba/netcmd/gpo.py b/python/samba/netcmd/gpo.py
>index 5d936e0e646..c5948a69857 100644
>--- a/python/samba/netcmd/gpo.py
>+++ b/python/samba/netcmd/gpo.py
>@@ -1296,6 +1296,10 @@ class cmd_create(GPOCommand):
>         else:
>             self.samdb.transaction_commit()
> 
>+        if tmpdir is None:
>+            # Without --tmpdir, we created one in /tmp/. It must go.
>+            shutil.rmtree(self.tmpdir)
>+
>         self.outf.write("GPO '%s' created as %s\n" % (displayname, gpo))
> 
> 
>-- 
>2.17.1
>

Actions: View

Attachments on bug 15006: 17238