Attachment 17220 Details for Bug 14983 – git-am fix for 4.16.rcNext, 4.15.next, 4.14.next.

[patch] git-am fix for 4.16.rcNext, 4.15.next, 4.14.next.

0001-s3-libsmb-Fix-errno-for-failed-authentication-in-SMB.patch (text/plain), 1.50 KB, created by Jeremy Allison on 2022-03-16 21:32:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2022-03-16 21:32:10 UTC

Size: 1.50 KB

patch

obsolete

>From b84860b984f50db2f722343b48e3b1ae2d460a3b Mon Sep 17 00:00:00 2001
>From: Elia Geretto <elia.f.geretto@gmail.com>
>Date: Fri, 11 Mar 2022 19:32:30 +0100
>Subject: [PATCH] s3:libsmb: Fix errno for failed authentication in
> SMBC_server_internal()
>
>In SMBC_server_internal(), when authentication fails, the errno value is
>currently hard-coded to EPERM, while it should be EACCES instead. Use the
>NT_STATUS map to set the appropriate value.
>
>This bug was found because it breaks listing printers protected by
>authentication in GNOME Control Panel.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14983
>
>Signed-off-by: Elia Geretto <elia.f.geretto@gmail.com>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>Reviewed-by: Volker Lendecke <vl@samba.org>
>
>Autobuild-User(master): Jeremy Allison <jra@samba.org>
>Autobuild-Date(master): Wed Mar 16 19:44:18 UTC 2022 on sn-devel-184
>
>(cherry picked from commit 70b9977a46e5242174b4461a7f49d5f640c1db62)
>---
> source3/libsmb/libsmb_server.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source3/libsmb/libsmb_server.c b/source3/libsmb/libsmb_server.c
>index b92477c88fe..09d27868c0e 100644
>--- a/source3/libsmb/libsmb_server.c
>+++ b/source3/libsmb/libsmb_server.c
>@@ -572,7 +572,7 @@ SMBC_server_internal(TALLOC_CTX *ctx,
> 		    !NT_STATUS_IS_OK(cli_session_setup_anon(c))) {
> 
>                         cli_shutdown(c);
>-                        errno = EPERM;
>+			errno = map_errno_from_nt_status(status);
>                         return NULL;
>                 }
> 	}
>-- 
>2.32.0
>

Flags:

metze: review+

Actions: View

Attachments on bug 14983: 17220