Attachment 17051 Details for Bug 14923 – Patch for 4.14 and 4.15 cherry-picked from master

[patch] Patch for 4.14 and 4.15 cherry-picked from master

bug14923-v414,v415.patch (text/plain), 1.20 KB, created by Ralph Böhme on 2021-12-07 17:07:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralph Böhme

Created: 2021-12-07 17:07:05 UTC

Size: 1.20 KB

patch

obsolete

>From 0ef9fe22f56ef3ff202f88426c3ee48c15e4a71e Mon Sep 17 00:00:00 2001
>From: Ralph Boehme <slow@samba.org>
>Date: Fri, 26 Nov 2021 11:59:45 +0100
>Subject: [PATCH] smbd: s3-dsgetdcname: handle num_ips == 0
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14923
>
>Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
>Signed-off-by: Ralph Boehme <slow@samba.org>
>Signed-off-by: Stefan Metzmacher <metze@samba.org>
>Reviewed-by: Guenther Deschner <gd@samba.org>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>
>Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
>Autobuild-Date(master): Fri Dec  3 12:54:04 UTC 2021 on sn-devel-184
>
>(cherry picked from commit 5e3df5f9ee64a80898f73585b19113354f463c44)
>---
> source3/libsmb/dsgetdcname.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/source3/libsmb/dsgetdcname.c b/source3/libsmb/dsgetdcname.c
>index f8ae96109b71..5954e48d747b 100644
>--- a/source3/libsmb/dsgetdcname.c
>+++ b/source3/libsmb/dsgetdcname.c
>@@ -572,6 +572,10 @@ static NTSTATUS discover_dc_dns(TALLOC_CTX *mem_ctx,
> 	for (i = 0; i < numdcs; i++) {
> 		size_t j;
> 
>+		if (dcs[i].num_ips == 0) {
>+			continue;
>+		}
>+
> 		dclist[ret_count].hostname =
> 			talloc_move(dclist, &dcs[i].hostname);
> 
>-- 
>2.33.1
>

Flags:

metze: review+
asn: review+

Actions: View

Attachments on bug 14923: 17051