Attachment 16810 Details for Bug 14841 – patch backported to 4.13 and 4.14

[patch] patch backported to 4.13 and 4.14

4-14-and-4-13-0001-autobuild-allow-AUTOBUILD_FAIL_IMMEDIATELY-0-say-fro.patch (text/plain), 1.79 KB, created by Andrew Bartlett on 2021-09-22 00:49:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Bartlett

Created: 2021-09-22 00:49:59 UTC

Size: 1.79 KB

patch

obsolete

>From 03801f4f3fdc7b10c33faec7b387a8e2d95b6b09 Mon Sep 17 00:00:00 2001
>From: Andrew Bartlett <abartlet@samba.org>
>Date: Fri, 17 Sep 2021 16:43:00 +1200
>Subject: [PATCH] autobuild: allow AUTOBUILD_FAIL_IMMEDIATELY=0 (say from a
> gitlab variable)
>
>This allows making a push to do a full test ignoring errors without
>needing "HACK!!!" commits on top.
>
>Use like this:
>
>git push -o ci.variable='AUTOBUILD_FAIL_IMMEDIATELY=0'
>
>RN: Samba CI runs can now continue past the first error if AUTOBUILD_FAIL_IMMEDIATELY=0 is set
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14841
>
>Signed-off-by: Andrew Bartlett <abartlet@samba.org>
>Reviewed-by: Michael Adam <obnox@samba.org
>Reviewed-by: Noel Power <npower@samba.org>
>
>[abartlet@samba.org backported from commit b81f6f3d71487085bb355392ce7f8eff2db5bb4d
> due to changes in 4.15 and later for the autobuild dependent jobs work
> that avoids rebuilding Samba in each task]
>---
> script/autobuild.py | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/script/autobuild.py b/script/autobuild.py
>index dded5c9dec9..c069e1d3ccd 100755
>--- a/script/autobuild.py
>+++ b/script/autobuild.py
>@@ -159,7 +159,6 @@ def format_option(name, value=None):
> 
> def make_test(
>         cmd='make test',
>-        FAIL_IMMEDIATELY=1,
>         TESTS='',
>         include_envs=None,
>         exclude_envs=None):
>@@ -174,7 +173,13 @@ def make_test(
>         TESTS = (TESTS + ' ' + ' '.join(test_options)).strip()
> 
>     _options = []
>-    if FAIL_IMMEDIATELY:
>+
>+    # Allow getting a full CI with
>+    # git push -o ci.variable='AUTOBUILD_FAIL_IMMEDIATELY=0'
>+
>+    FAIL_IMMEDIATELY = os.getenv("AUTOBUILD_FAIL_IMMEDIATELY", "1")
>+
>+    if int(FAIL_IMMEDIATELY):
>         _options.append('FAIL_IMMEDIATELY=1')
>     if TESTS:
>         _options.append("TESTS='{}'".format(TESTS))
>-- 
>2.25.1
>

Flags:

npower: review+

Actions: View

Attachments on bug 14841: 16809 | 16810