Attachment 16603 Details for Bug 14696 – git-am fix for 4.14.next, 4.13.next.

[patch] git-am fix for 4.14.next, 4.13.next.

0001-s3-smbd-SMB1-SMBsplwr-doesn-t-send-a-reply-packet-on.patch (text/plain), 1.04 KB, created by Jeremy Allison on 2021-04-29 21:46:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2021-04-29 21:46:51 UTC

Size: 1.04 KB

patch

obsolete

>From 534951934cdedbbd4c67c88561174f4c1d767ac4 Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Thu, 29 Apr 2021 09:50:30 -0700
>Subject: [PATCH] s3: smbd: SMB1 SMBsplwr doesn't send a reply packet on
> success.
>
>Missing call to set up req->outbuf means no reply is sent.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14696
>
>Signed-off-by: Jeremy Allison <jra@samba.org>
>Reviewed-by: Ralph Boehme <slow@samba.org>
>
>Autobuild-User(master): Jeremy Allison <jra@samba.org>
>Autobuild-Date(master): Thu Apr 29 21:27:58 UTC 2021 on sn-devel-184
>
>(cherry picked from commit 47d79d7e7e406f7dd204ded7c72cfed3e0761ad5)
>---
> source3/smbd/reply.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c
>index 8bfe15510c4..834fd484192 100644
>--- a/source3/smbd/reply.c
>+++ b/source3/smbd/reply.c
>@@ -7052,6 +7052,8 @@ void reply_printwrite(struct smb_request *req)
> 
> 	DEBUG(3, ("printwrite %s num=%d\n", fsp_fnum_dbg(fsp), numtowrite));
> 
>+	reply_outbuf(req, 0, 0);
>+
> 	END_PROFILE(SMBsplwr);
> 	return;
> }
>-- 
>2.27.0
>

Flags:

slow: review+

Actions: View

Attachments on bug 14696: 16600 | 16602 | 16603