Attachment 16552 Details for Bug 14672 – Possible patch for master (and older versions)

[patch] Possible patch for master (and older versions)

master-bug14672.patch (text/plain), 1.32 KB, created by Ralph Böhme on 2021-03-16 20:41:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralph Böhme

Created: 2021-03-16 20:41:35 UTC

Size: 1.32 KB

patch

obsolete

>From 13a766accfd435cc480e726d34638be3e549808a Mon Sep 17 00:00:00 2001
>From: Ralph Boehme <slow@samba.org>
>Date: Tue, 16 Mar 2021 18:18:46 +0100
>Subject: [PATCH] smbd: free open_rec state in
> remove_deferred_open_message_smb2_internal()
>
>The lifetime of open_rec (struct deferred_open_record) ojects is the time
>processing the SMB open request every time the request is scheduled, ie once we
>reschedule we must wipe the slate clean. In case the request gets deferred
>again, a new open_rec will be created by the schedule functions.
>
>This ensures any timer event tied to the open_rec gets cancelled and doesn't
>fire unexpectedly.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14672
>CI: https://gitlab.com/samba-team/samba/-/merge_requests/1843
>RN: smbd panic when two clients open same file
>---
> source3/smbd/smb2_create.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/source3/smbd/smb2_create.c b/source3/smbd/smb2_create.c
>index 2dd3745dd32..8ff57c94aa0 100644
>--- a/source3/smbd/smb2_create.c
>+++ b/source3/smbd/smb2_create.c
>@@ -1714,6 +1714,7 @@ static void remove_deferred_open_message_smb2_internal(struct smbd_smb2_request
> 	state->open_was_deferred = false;
> 	/* Ensure we don't have any outstanding immediate event. */
> 	TALLOC_FREE(state->im);
>+	TALLOC_FREE(state->open_rec);
> }
> 
> void remove_deferred_open_message_smb2(
>-- 
>2.30.2
>

Actions: View

Attachments on bug 14672: 16549 | 16550 | 16552 | 16554 | 16557