Attachment 16514 Details for Bug 14658 – raw patch to remove lpcfg_add_home()

[patch] raw patch to remove lpcfg_add_home()

l1 (text/plain), 2.09 KB, created by Jeremy Allison on 2021-03-10 02:24:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2021-03-10 02:24:03 UTC

Size: 2.09 KB

patch

obsolete

>diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c
>index 3548c47d857..873692cf2a9 100644
>--- a/lib/param/loadparm.c
>+++ b/lib/param/loadparm.c
>@@ -728,42 +728,6 @@ struct loadparm_service *lpcfg_add_service(struct loadparm_context *lp_ctx,
> 	return lp_ctx->services[i];
> }
> 
>-/**
>- * Add a new home service, with the specified home directory, defaults coming
>- * from service ifrom.
>- */
>-
>-bool lpcfg_add_home(struct loadparm_context *lp_ctx,
>-		 const char *pszHomename,
>-		 struct loadparm_service *default_service,
>-		 const char *user, const char *pszHomedir)
>-{
>-	struct loadparm_service *service;
>-
>-	service = lpcfg_add_service(lp_ctx, default_service, pszHomename);
>-
>-	if (service == NULL)
>-		return false;
>-
>-	if (!(*(default_service->path))
>-	    || strequal(default_service->path, lp_ctx->sDefault->path)) {
>-		service->path = talloc_strdup(service, pszHomedir);
>-	} else {
>-		service->path = string_sub_talloc(service, lpcfg_path(default_service, lp_ctx->sDefault, service), "%H", pszHomedir);
>-	}
>-
>-	if (!(*(service->comment))) {
>-		service->comment = talloc_asprintf(service, "Home directory of %s", user);
>-	}
>-	service->available = default_service->available;
>-	service->browseable = default_service->browseable;
>-
>-	DEBUG(3, ("adding home's share [%s] for user '%s' at '%s'\n",
>-		  pszHomename, user, service->path));
>-
>-	return true;
>-}
>-
> /**
>  * Add a new printer service, with defaults coming from service iFrom.
>  */
>diff --git a/lib/param/param.h b/lib/param/param.h
>index f7204c5702d..71f1ca7c233 100644
>--- a/lib/param/param.h
>+++ b/lib/param/param.h
>@@ -116,10 +116,6 @@ bool lpcfg_parm_bool(struct loadparm_context *lp_ctx,
> struct loadparm_service *lpcfg_add_service(struct loadparm_context *lp_ctx,
> 				     const struct loadparm_service *pservice,
> 				     const char *name);
>-bool lpcfg_add_home(struct loadparm_context *lp_ctx,
>-		 const char *pszHomename,
>-		 struct loadparm_service *default_service,
>-		 const char *user, const char *pszHomedir);
> bool lpcfg_add_printer(struct loadparm_context *lp_ctx,
> 		    const char *pszPrintername,
> 		    struct loadparm_service *default_service);

Actions: View

Attachments on bug 14658: 16513 | 16514