Attachment 16494 Details for Bug 14288 – backported fix for 4.14, 4.13, 4.12

[patch] backported fix for 4.14, 4.13, 4.12

0001-wscript-use-as-needed-only-if-tested-successfully.patch (text/plain), 1.00 KB, created by Björn Jacke on 2021-03-03 13:27:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Björn Jacke

Created: 2021-03-03 13:27:09 UTC

Size: 1.00 KB

patch

obsolete

>From e9d26d761f74b991da6cf1c0bc0934e9f5858f79 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Bj=C3=B6rn=20Jacke?= <bj@sernet.de>
>Date: Tue, 2 Mar 2021 22:47:35 +0100
>Subject: [PATCH] wscript: use --as-needed only if tested successfully
>
>Some OSes like Solaris based OmiOS don't support this.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14288
>
>Signed-off-by: Bjoern Jacke <bjacke@samba.org>
>Reviewed-by: Andrew Bartlett <abartlet@samba.org>
>(cherry picked from commit 996560191ac6bd603901dcd6c0de5d239e019ef4)
>---
> wscript | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/wscript b/wscript
>index 334b2988234..3c6b130bd22 100644
>--- a/wscript
>+++ b/wscript
>@@ -340,7 +340,8 @@ def configure(conf):
>     # allows us to find problems on our development hosts faster.
>     # It also results in faster load time.
> 
>-    conf.add_as_needed()
>+    conf.ADD_LDFLAGS('-Wl,--as-needed', testflags=True)
>+
> 
>     if not conf.CHECK_NEED_LC("-lc not needed"):
>         conf.ADD_LDFLAGS('-lc', testflags=False)
>-- 
>2.20.2
>

Flags:

bjacke: review+

Actions: View

Attachments on bug 14288: 15812 | 16494 | 16588