Attachment 16438 Details for Bug 14631 – Possible patch

[patch] Possible patch

tmp.patch (text/plain), 1.55 KB, created by Ralph Böhme on 2021-02-08 14:08:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ralph Böhme

Created: 2021-02-08 14:08:43 UTC

Size: 1.55 KB

patch

obsolete

>From 1ca779346125b115d98c9df9034408ba70cc88be Mon Sep 17 00:00:00 2001
>From: Ralph Boehme <slow@samba.org>
>Date: Mon, 8 Feb 2021 15:05:18 +0100
>Subject: [PATCH 1/2] smbd: set SEC_DESC_SACL_AUTO_INHERITED in
> make_default_filesystem_acl()
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14631
>---
> source3/smbd/posix_acls.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/source3/smbd/posix_acls.c b/source3/smbd/posix_acls.c
>index c1d5b7cd047..13847623810 100644
>--- a/source3/smbd/posix_acls.c
>+++ b/source3/smbd/posix_acls.c
>@@ -4990,5 +4990,9 @@ NTSTATUS make_default_filesystem_acl(
> 		break;
> 	}
> 
>+	if (NT_STATUS_IS_OK(status)) {
>+		(*ppdesc)->type |= SEC_DESC_SACL_AUTO_INHERITED;
>+	}
>+
> 	return status;
> }
>-- 
>2.29.2
>
>
>From 2f361a956aa98dd0bd542d492d3d2dd5564920ac Mon Sep 17 00:00:00 2001
>From: Ralph Boehme <slow@samba.org>
>Date: Mon, 8 Feb 2021 15:05:42 +0100
>Subject: [PATCH 2/2] vfs_acl_[xattr|tdb]: set SEC_DESC_SACL_AUTO_INHERITED
> when synthesizing ACL from filesystem
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14631
>---
> source3/modules/vfs_acl_common.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/source3/modules/vfs_acl_common.c b/source3/modules/vfs_acl_common.c
>index db6f40d3adf..1eb0c6d40d3 100644
>--- a/source3/modules/vfs_acl_common.c
>+++ b/source3/modules/vfs_acl_common.c
>@@ -712,6 +712,7 @@ NTSTATUS fget_nt_acl_common(
> 		 * this way under POSIX. Remove it for Windows-style ACLs.
> 		 */
> 		psd->type &= ~SEC_DESC_DACL_PROTECTED;
>+		psd->type |= SEC_DESC_SACL_AUTO_INHERITED;
> 	}
> 
> 	if (!(security_info & SECINFO_OWNER)) {
>-- 
>2.29.2
>

Actions: View

Attachments on bug 14631: 16430 | 16431 | 16432 | 16433 | 16438