Attachment 16355 Details for Bug 14486 – follow up patch for 4.12 and 4.13

[patch] follow up patch for 4.12 and 4.13

v4-12.patch (text/plain), 3.94 KB, created by Anoop C S on 2020-12-02 05:53:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Anoop C S

Created: 2020-12-02 05:53:04 UTC

Size: 3.94 KB

patch

obsolete

>From 0d2046f7915fc04975c30cbf506e59b855a5a6d3 Mon Sep 17 00:00:00 2001
>From: Anoop C S <anoopcs@samba.org>
>Date: Thu, 5 Nov 2020 16:12:09 +0530
>Subject: [PATCH 1/2] manpages/vfs_glusterfs: Mention silent skipping of
> write-behind translator
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14486
>
>Signed-off-by: Anoop C S <anoopcs@samba.org>
>Reviewed-by: Andrew Bartlett <abartlet@samba.org>
>Reviewed-by: Guenther Deschner <gd@samba.org>
>
>Autobuild-User(master): GÃÂ¼nther Deschner <gd@samba.org>
>Autobuild-Date(master): Mon Nov  9 13:30:06 UTC 2020 on sn-devel-184
>
>(cherry picked from commit be03ce7d8bb213633eedcfc3299b8d9865a3c67f)
>---
> docs-xml/manpages/vfs_glusterfs.8.xml | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/docs-xml/manpages/vfs_glusterfs.8.xml b/docs-xml/manpages/vfs_glusterfs.8.xml
>index 7a4da1af919..ca6085a0595 100644
>--- a/docs-xml/manpages/vfs_glusterfs.8.xml
>+++ b/docs-xml/manpages/vfs_glusterfs.8.xml
>@@ -180,6 +180,11 @@
>                 Please disable the write-behind translator for the GlusterFS
>                 volume to allow the plugin to connect to the volume.
> 	</para>
>+        <para>
>+                With GlusterFS versions >= 9, we silently bypass write-behind
>+                translator during intial connect and failure is avoided.
>+        </para>
>+
> </refsect1>
> 
> 
>-- 
>2.28.0
>
>
>From 67f7d9ee58ab08b81744dd5f3d50ac5c35bceb60 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?G=C3=BCnther=20Deschner?= <gd@samba.org>
>Date: Tue, 24 Nov 2020 15:38:41 +0100
>Subject: [PATCH 2/2] vfs_glusterfs: print exact cmdline for disabling
> write-behind translator
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14486
>
>Guenther
>
>Signed-off-by: Guenther Deschner <gd@samba.org>
>Reviewed-by: Anoop C S <anoopcs@samba.org>
>
>Autobuild-User(master): GÃ¼nther Deschner <gd@samba.org>
>Autobuild-Date(master): Fri Nov 27 17:15:07 UTC 2020 on sn-devel-184
>
>(cherry picked from commit 369c1d539837b70e94fe9d533d44860c8a9380a1)
>---
> docs-xml/manpages/vfs_glusterfs.8.xml | 6 +++++-
> source3/modules/vfs_glusterfs.c       | 7 +++++--
> 2 files changed, 10 insertions(+), 3 deletions(-)
>
>diff --git a/docs-xml/manpages/vfs_glusterfs.8.xml b/docs-xml/manpages/vfs_glusterfs.8.xml
>index ca6085a0595..d25135e14ac 100644
>--- a/docs-xml/manpages/vfs_glusterfs.8.xml
>+++ b/docs-xml/manpages/vfs_glusterfs.8.xml
>@@ -179,10 +179,14 @@
>                 translator and refuse to connect if detected.
>                 Please disable the write-behind translator for the GlusterFS
>                 volume to allow the plugin to connect to the volume.
>+                The write-behind translator can easily be disabled via calling
>+                <programlisting>
>+                        gluster volume set &lt;volumename&gt; performance.write-behind off
>+                </programlisting> on the commandline.
> 	</para>
>         <para>
>                 With GlusterFS versions >= 9, we silently bypass write-behind
>-                translator during intial connect and failure is avoided.
>+                translator during initial connect and failure is avoided.
>         </para>
> 
> </refsect1>
>diff --git a/source3/modules/vfs_glusterfs.c b/source3/modules/vfs_glusterfs.c
>index c338674ac3c..ee73512e31b 100644
>--- a/source3/modules/vfs_glusterfs.c
>+++ b/source3/modules/vfs_glusterfs.c
>@@ -345,9 +345,12 @@ static int check_for_write_behind_translator(TALLOC_CTX *mem_ctx,
> 	if (write_behind_present) {
> 		DBG_ERR("Write behind translator is enabled for "
> 			"volume (%s), refusing to connect! "
>-			"Please check the vfs_glusterfs(8) manpage for "
>+			"Please turn off the write behind translator by calling "
>+			"'gluster volume set %s performance.write-behind off' "
>+			"on the commandline. "
>+			"Check the vfs_glusterfs(8) manpage for "
> 			"further details.\n",
>-			volume);
>+			volume, volume);
> 		return -1;
> 	}
> 
>-- 
>2.28.0
>

Flags:

gd: review+

Actions: View

Attachments on bug 14486: 16217 | 16218 | 16226 | 16319 | 16320 | 16322 | 16324 | 16333 | 16345 | 16346 | 16354 | 16355