Attachment 16337 Details for Bug 14210 – Updated git-am fix for master.

[patch] Updated git-am fix for master.

0001-libcli-smb2-Never-print-length-if-smb2_signing_key_v.patch (text/plain), 1.72 KB, created by Jeremy Allison on 2020-11-15 00:14:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jeremy Allison

Created: 2020-11-15 00:14:20 UTC

Size: 1.72 KB

patch

obsolete

>From 1b74b72e235b4ad3ad561b4ec267b4e2cd2dbd7f Mon Sep 17 00:00:00 2001
>From: Jeremy Allison <jra@samba.org>
>Date: Fri, 13 Nov 2020 14:18:43 -0800
>Subject: [PATCH] libcli: smb2: Never print length if smb2_signing_key_valid()
> fails for crypto blob.
>
>Blob could be NULL.
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14210
>
>Signed-off-by: Jeremy Allison <jra@samba.org>
>---
> libcli/smb/smb2_signing.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
>diff --git a/libcli/smb/smb2_signing.c b/libcli/smb/smb2_signing.c
>index 7669b219bbe..6ece5f2e4d3 100644
>--- a/libcli/smb/smb2_signing.c
>+++ b/libcli/smb/smb2_signing.c
>@@ -92,8 +92,7 @@ NTSTATUS smb2_signing_sign_pdu(struct smb2_signing_key *signing_key,
> 	}
> 
> 	if (!smb2_signing_key_valid(signing_key)) {
>-		DBG_WARNING("Wrong session key length %zu for SMB2 signing\n",
>-			    signing_key->blob.length);
>+		DBG_WARNING("No signing key for SMB2 signing\n");
> 		return NT_STATUS_ACCESS_DENIED;
> 	}
> 
>@@ -416,8 +415,7 @@ NTSTATUS smb2_signing_encrypt_pdu(struct smb2_signing_key *encryption_key,
> 	tf = (uint8_t *)vector[0].iov_base;
> 
> 	if (!smb2_signing_key_valid(encryption_key)) {
>-		DBG_WARNING("Wrong encryption key length %zu for SMB2 signing\n",
>-			    encryption_key->blob.length);
>+		DBG_WARNING("No encryption key for SMB2 signing\n");
> 		return NT_STATUS_ACCESS_DENIED;
> 	}
> 
>@@ -625,8 +623,7 @@ NTSTATUS smb2_signing_decrypt_pdu(struct smb2_signing_key *decryption_key,
> 	tf = (uint8_t *)vector[0].iov_base;
> 
> 	if (!smb2_signing_key_valid(decryption_key)) {
>-		DBG_WARNING("Wrong decryption key length %zu for SMB2 signing\n",
>-			    decryption_key->blob.length);
>+		DBG_WARNING("No decryption key for SMB2 signing\n");
> 		return NT_STATUS_ACCESS_DENIED;
> 	}
> 
>-- 
>2.27.0
>

Flags:

metze: review+

Actions: View

Attachments on bug 14210: 15652 | 15653 | 15654 | 15655 | 16336 | 16337 | 16338