Attachment 16317 Details for Bug 14555 – patch for 4.13

[patch] patch for 4.13

0001-s4-torture-Pass-buffer-correctly-to-write.patch (text/plain), 1.53 KB, created by Andreas Schneider on 2020-10-29 14:12:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Schneider

Created: 2020-10-29 14:12:22 UTC

Size: 1.53 KB

patch

obsolete

>From 7eff4931ac47d5a6acc3ccbd214ae6391776f52a Mon Sep 17 00:00:00 2001
>From: Andreas Schneider <asn@samba.org>
>Date: Wed, 28 Oct 2020 15:05:34 +0100
>Subject: [PATCH] s4:torture: Pass buffer correctly to write()
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>../../source4/torture/basic/denytest.c: In function âtorture_createx_specific.israâ:
>../../source4/torture/basic/denytest.c:2372:9: error: âwriteâ reading 56 bytes from a region of size 8 [-Werror=stringop-overflow=]
> 2372 |   res = write(data_file_fd, &cxd, cxd_len);
>      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
>BUG: https://bugzilla.samba.org/show_bug.cgi?id=14555
>
>Signed-off-by: Andreas Schneider <asn@samba.org>
>Reviewed-by: Alexander Bokovoy <ab@samba.org>
>Reviewed-by: Jeremy Allison <jra@samba.org>
>(cherry picked from commit 5f92ec6988d2f4c20eab9449cbe17317588f6634)
>---
> source4/torture/basic/denytest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/source4/torture/basic/denytest.c b/source4/torture/basic/denytest.c
>index 1c946b81b92..8e7a822df09 100644
>--- a/source4/torture/basic/denytest.c
>+++ b/source4/torture/basic/denytest.c
>@@ -2369,7 +2369,7 @@ static bool torture_createx_specific(struct torture_context *tctx, struct
> 	if (data_file_fd >= 0) {
> 		size_t cxd_len = sizeof(struct createx_data);
> 		found = true;
>-		res = write(data_file_fd, &cxd, cxd_len);
>+		res = write(data_file_fd, cxd, cxd_len);
> 		if (res != cxd_len) {
> 			torture_result(tctx, TORTURE_FAIL,
> 				"(%s): write failed: %s!",
>-- 
>2.29.1
>

Flags:

ab: review+

Actions: View

Attachments on bug 14555: 16317