Attachment 16116 Details for Bug 14430 – Patch to open many notifies on a single connection and directory

[patch] Patch to open many notifies on a single connection and directory

patch.txt (text/plain), 5.94 KB, created by Volker Lendecke on 2020-07-07 12:32:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Volker Lendecke

Created: 2020-07-07 12:32:27 UTC

Size: 5.94 KB

patch

obsolete

>From 3dd5eae061928195fef58bff02c4b2b4754fdf1e Mon Sep 17 00:00:00 2001
>From: Volker Lendecke <vl@samba.org>
>Date: Tue, 7 Jul 2020 09:25:20 +0200
>Subject: [PATCH] notify-bench4
>
>---
> source3/torture/proto.h       |   1 +
> source3/torture/test_notify.c | 178 ++++++++++++++++++++++++++++++++++
> source3/torture/torture.c     |   4 +
> 3 files changed, 183 insertions(+)
>
>diff --git a/source3/torture/proto.h b/source3/torture/proto.h
>index 18e686089ed..00fa113e6e2 100644
>--- a/source3/torture/proto.h
>+++ b/source3/torture/proto.h
>@@ -113,6 +113,7 @@ bool run_cleanup2(int dummy);
> bool run_cleanup4(int dummy);
> bool run_notify_bench2(int dummy);
> bool run_notify_bench3(int dummy);
>+bool run_notify_bench4(int dummy);
> bool run_dbwrap_watch1(int dummy);
> bool run_dbwrap_watch2(int dummy);
> bool run_dbwrap_watch3(int dummy);
>diff --git a/source3/torture/test_notify.c b/source3/torture/test_notify.c
>index 33c2381fbbd..40881472e2a 100644
>--- a/source3/torture/test_notify.c
>+++ b/source3/torture/test_notify.c
>@@ -726,3 +726,181 @@ bool run_notify_bench3(int dummy)
> 	TALLOC_FREE(large);
> 	return true;
> }
>+
>+struct notify_bench4_state {
>+	struct tevent_context *ev;
>+	struct cli_state *cli;
>+	uint16_t dnum;
>+};
>+
>+static void notify_bench4_opened(struct tevent_req *subreq);
>+static void notify_bench4_notified(struct tevent_req *subreq);
>+static void notify_bench4_echoed(struct tevent_req *subreq);
>+
>+static struct tevent_req *notify_bench4_send(
>+	TALLOC_CTX *mem_ctx,
>+	struct tevent_context *ev,
>+	struct cli_state *cli,
>+	const char *dname)
>+{
>+	struct tevent_req *req = NULL, *subreq = NULL;
>+	struct notify_bench4_state *state = NULL;
>+
>+	req = tevent_req_create(mem_ctx, &state, struct notify_bench4_state);
>+	if (req == NULL) {
>+		return NULL;
>+	}
>+	state->ev = ev;
>+	state->cli = cli;
>+
>+	subreq = cli_ntcreate_send(
>+		state,		/* mem_ctx */
>+		ev,		/* ev */
>+		cli,		/* cli */
>+		dname,		/* dname */
>+		0,		/* create_flags */
>+		SEC_FILE_READ_DATA|
>+		SEC_FILE_READ_ATTRIBUTE, /* desired_access */
>+		0,			 /* file_attributes */
>+		FILE_SHARE_READ|
>+		FILE_SHARE_WRITE|
>+		FILE_SHARE_DELETE, /* share_access */
>+		FILE_OPEN,	   /* create_disposition */
>+		FILE_DIRECTORY_FILE, /* create_options */
>+		SMB2_IMPERSONATION_IMPERSONATION, /* impersonation_level */
>+		0);				  /* security_flags */
>+	if (tevent_req_nomem(subreq, req)) {
>+		return tevent_req_post(req, ev);
>+	}
>+	tevent_req_set_callback(subreq, notify_bench4_opened, req);
>+	return req;
>+}
>+
>+static void notify_bench4_opened(struct tevent_req *subreq)
>+{
>+	struct tevent_req *req = tevent_req_callback_data(
>+		subreq, struct tevent_req);
>+	struct notify_bench4_state *state = tevent_req_data(
>+		req, struct notify_bench4_state);
>+	NTSTATUS status;
>+
>+	status = cli_ntcreate_recv(subreq, &state->dnum, NULL);
>+	TALLOC_FREE(subreq);
>+	if (tevent_req_nterror(req, status)) {
>+		return;
>+	}
>+
>+	subreq = cli_notify_send(
>+		state,		/* mem_ctx */
>+		state->ev,	/* ev */
>+		state->cli,	/* cli */
>+		state->dnum,	/* fnum */
>+		32,		/* buffer_size */
>+		FILE_NOTIFY_CHANGE_FILE_NAME|
>+		FILE_NOTIFY_CHANGE_DIR_NAME|
>+		FILE_NOTIFY_CHANGE_ATTRIBUTES|
>+		FILE_NOTIFY_CHANGE_SIZE|
>+		FILE_NOTIFY_CHANGE_LAST_WRITE|
>+		FILE_NOTIFY_CHANGE_LAST_ACCESS|
>+		FILE_NOTIFY_CHANGE_CREATION|
>+		FILE_NOTIFY_CHANGE_SECURITY, /* completion_filter */
>+		false);
>+	if (tevent_req_nomem(subreq, req)) {
>+		return;
>+	}
>+	tevent_req_set_callback(subreq, notify_bench4_notified, req);
>+
>+	/*
>+	 * Make sure the notify was delivered to the server
>+	 */
>+	subreq = cli_echo_send(
>+		state,		/* mem_ctx */
>+		state->ev,	/* ev */
>+		state->cli,	/* cli */
>+		1,		/* num_echos */
>+		(DATA_BLOB){0});	/* data */
>+	if (tevent_req_nomem(subreq, req)) {
>+		return;
>+	}
>+	tevent_req_set_callback(subreq, notify_bench4_echoed, req);
>+}
>+
>+static void notify_bench4_notified(struct tevent_req *subreq)
>+{
>+	struct tevent_req *req = tevent_req_callback_data(
>+		subreq, struct tevent_req);
>+	struct notify_bench4_state *state = tevent_req_data(
>+		req, struct notify_bench4_state);
>+	uint32_t num_changes;
>+	struct notify_change *changes = NULL;
>+	NTSTATUS status;
>+
>+	status = cli_notify_recv(
>+		subreq, state, &num_changes, &changes);
>+	TALLOC_FREE(subreq);
>+	if (tevent_req_nterror(req, status)) {
>+		return;
>+	}
>+
>+	printf("Got %"PRIu32" changes\n", num_changes);
>+
>+	TALLOC_FREE(changes);
>+
>+	tevent_req_done(req);
>+}
>+
>+static void notify_bench4_echoed(struct tevent_req *subreq)
>+{
>+	struct tevent_req *req = tevent_req_callback_data(
>+		subreq, struct tevent_req);
>+	NTSTATUS status;
>+
>+	status = cli_echo_recv(subreq);
>+	TALLOC_FREE(subreq);
>+	if (tevent_req_nterror(subreq, status)) {
>+		return;
>+	}
>+	tevent_req_done(req);
>+}
>+
>+static NTSTATUS notify_bench4_recv(struct tevent_req *req, uint16_t *dnum)
>+{
>+	struct notify_bench4_state *state = tevent_req_data(
>+		req, struct notify_bench4_state);
>+	NTSTATUS status;
>+
>+	if (tevent_req_is_nterror(req, &status)) {
>+		return status;
>+	}
>+	*dnum = state->dnum;
>+	return NT_STATUS_OK;
>+}
>+
>+bool run_notify_bench4(int dummy)
>+{
>+	struct cli_state *cli = NULL;
>+	struct tevent_context *ev = NULL;
>+	NTSTATUS status;
>+
>+	printf("Starting to open many notifies on one directory\n");
>+
>+	if (!torture_open_connection(&cli, 0)) {
>+		return false;
>+	}
>+
>+	cli_rmdir(cli, "\\notify.dir\\subdir");
>+	cli_rmdir(cli, "\\notify.dir");
>+
>+	status = cli_mkdir(cli, "\\notify.dir");
>+	if (!NT_STATUS_IS_OK(status)) {
>+		printf("mkdir failed : %s\n", nt_errstr(status));
>+		return false;
>+	}
>+	status = cli_mkdir(cli, "\\notify.dir\\subdir");
>+	if (!NT_STATUS_IS_OK(status)) {
>+		printf("mkdir failed : %s\n", nt_errstr(status));
>+		return false;
>+	}
>+
>+	return false;
>+}
>diff --git a/source3/torture/torture.c b/source3/torture/torture.c
>index 2a3133373e9..7083ec6b3a6 100644
>--- a/source3/torture/torture.c
>+++ b/source3/torture/torture.c
>@@ -14787,6 +14787,10 @@ static struct {
> 		.name  = "NOTIFY-BENCH3",
> 		.fn    = run_notify_bench3,
> 	},
>+	{
>+		.name  = "NOTIFY-BENCH4",
>+		.fn    = run_notify_bench4,
>+	},
> 	{
> 		.name  = "BAD-NBT-SESSION",
> 		.fn    = run_bad_nbt_session,
>-- 
>2.20.1
>

Actions: View

Attachments on bug 14430: 16109 | 16115 | 16116 | 16117 | 16118